jpountz commented on code in PR #13596:
URL: https://github.com/apache/lucene/pull/13596#discussion_r1753788413
##########
lucene/test-framework/src/java/org/apache/lucene/tests/index/PerThreadPKLookup.java:
##########
@@ -97,5 +174,28 @@ public int lookup(BytesRef id) throws IOException {
return -1;
}
- // TODO: add reopen method to carry over re-used enums...?
+ /**
+ * Reuse loaded segments' termsEnum and postingsEnum.
+ *
+ * @return null if there are no changes; else, a new PerThreadPKLookup
instance which you must
+ * eventually close its reader by {@link #closeReader}.
+ * @throws IOException if there is a low-level IO error.
+ */
+ public PerThreadPKLookup reopen() throws IOException {
+ DirectoryReader newReader =
DirectoryReader.openIfChanged((DirectoryReader) reader);
+ if (newReader == null) {
+ return null;
+ }
+
+ return new PerThreadPKLookup(this, newReader);
Review Comment:
Argh sorry, for some reason I overlooked this logic. Indeed it would be
better to use the result of `getCoreCacheHelper().getKey()` than the
SegmentInfo object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
