asfgit merged PR #12747:
URL: https://github.com/apache/lucene/pull/12747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
rmuir commented on code in PR #12747:
URL: https://github.com/apache/lucene/pull/12747#discussion_r1380018590
##
lucene/benchmark-jmh/src/java/org/apache/lucene/benchmark/jmh/VectorUtilBenchmark.java:
##
@@ -56,84 +62,72 @@ public void init() {
}
@Benchmark
- @Fork(valu
rmuir commented on code in PR #12747:
URL: https://github.com/apache/lucene/pull/12747#discussion_r1380017854
##
lucene/benchmark-jmh/src/java/org/apache/lucene/benchmark/jmh/VectorUtilBenchmark.java:
##
@@ -56,84 +62,72 @@ public void init() {
}
@Benchmark
- @Fork(valu
rmuir commented on code in PR #12747:
URL: https://github.com/apache/lucene/pull/12747#discussion_r1380016895
##
lucene/benchmark-jmh/src/java/org/apache/lucene/benchmark/jmh/VectorUtilBenchmark.java:
##
@@ -24,8 +24,14 @@
@BenchmarkMode(Mode.Throughput)
@OutputTimeUnit(TimeUn
mikemccand commented on code in PR #12747:
URL: https://github.com/apache/lucene/pull/12747#discussion_r1379747014
##
lucene/benchmark-jmh/src/java/org/apache/lucene/benchmark/jmh/VectorUtilBenchmark.java:
##
@@ -24,8 +24,14 @@
@BenchmarkMode(Mode.Throughput)
@OutputTimeUnit(T
rmuir commented on PR #12747:
URL: https://github.com/apache/lucene/pull/12747#issuecomment-1790041666
and i know it is annoying it runs slower, i really tried to not be overkill,
but some methods here are super simple and super stable and some are unstable.
So I gave all methods minimum 3
rmuir opened a new pull request, #12747:
URL: https://github.com/apache/lucene/pull/12747
This benchmark is too noisy across forks which makes comparisons impossible
and misleading. Especially vectorized float methods on some machines: it is
almost useless.
I spent some time to reduc
