rmuir commented on code in PR #12747:
URL: https://github.com/apache/lucene/pull/12747#discussion_r1380017854
##########
lucene/benchmark-jmh/src/java/org/apache/lucene/benchmark/jmh/VectorUtilBenchmark.java:
##########
@@ -56,84 +62,72 @@ public void init() {
}
@Benchmark
- @Fork(value = 1)
public float binaryCosineScalar() {
return VectorUtil.cosine(bytesA, bytesB);
}
@Benchmark
- @Fork(
- value = 1,
- jvmArgsPrepend = {"--add-modules=jdk.incubator.vector"})
+ @Fork(jvmArgsPrepend = {"--add-modules=jdk.incubator.vector"})
public float binaryCosineVector() {
return VectorUtil.cosine(bytesA, bytesB);
}
@Benchmark
- @Fork(value = 1)
public int binaryDotProductScalar() {
return VectorUtil.dotProduct(bytesA, bytesB);
}
@Benchmark
- @Fork(
- value = 1,
- jvmArgsPrepend = {"--add-modules=jdk.incubator.vector"})
+ @Fork(jvmArgsPrepend = {"--add-modules=jdk.incubator.vector"})
public int binaryDotProductVector() {
return VectorUtil.dotProduct(bytesA, bytesB);
}
@Benchmark
- @Fork(value = 1)
public int binarySquareScalar() {
return VectorUtil.squareDistance(bytesA, bytesB);
}
@Benchmark
- @Fork(
- value = 1,
Review Comment:
it is the same annotation at both class and method. instead of setting
`value=1` on every method, we set it to 3 by default on the class, and override
it (crank to 15) for a couple super-noisy methods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
