rmuir merged PR #12667:
URL: https://github.com/apache/lucene/pull/12667
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
rmuir commented on PR #12667:
URL: https://github.com/apache/lucene/pull/12667#issuecomment-1762210828
The logging works correctly for my use-case (accidentally running java 17).
Scalar method has no warnings, Vector method prints: `WARNING: Java vector
incubator module was enabled by comma
uschindler commented on PR #12667:
URL: https://github.com/apache/lucene/pull/12667#issuecomment-1762144670
@rmuir I merged main barnch here, so you can retest the better logging of
#12676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
uschindler commented on PR #12667:
URL: https://github.com/apache/lucene/pull/12667#issuecomment-1762118934
> Did it also happen when it was started with -jar ("classpath" mode)? I
don't think it should, right?
Naaah, that was the most confusing part.
--
This is an automated messag
dweiss commented on PR #12667:
URL: https://github.com/apache/lucene/pull/12667#issuecomment-1762019283
> The problem was: if you run the benchmark in module mode, the requirement
added the module without respecting if the extra runtime parameter was given.
Yep, I understand. Did it a
uschindler commented on PR #12667:
URL: https://github.com/apache/lucene/pull/12667#issuecomment-1761946068
> Yeah, i think its better not to compile benchmarks with incubator/preview
etc? I think benchmarks should just call lucene methods, and lucene code should
do the right thing with han
uschindler commented on PR #12667:
URL: https://github.com/apache/lucene/pull/12667#issuecomment-1761940947
I ran all benchmarks in module mode (second line of assemble output) on my
AVX-256 laptop:
Prozessor: Intel(R) Core(TM) i7-8565U CPU @ 1.80GHz, 1992 MHz, 4 Kern(e),
8 logisch
rmuir commented on PR #12667:
URL: https://github.com/apache/lucene/pull/12667#issuecomment-1761796246
Yeah, i think its better not to compile benchmarks with incubator/preview
etc? I think benchmarks should just call lucene methods, and lucene code should
do the right thing with handling i
uschindler commented on PR #12667:
URL: https://github.com/apache/lucene/pull/12667#issuecomment-1761741178
> > The jdk.incubator.vector must be removed from the module-info.java file.
>
> This was intentional, otherwise the example benchmark wouldn't compile...
But since the vectors-
dweiss commented on PR #12667:
URL: https://github.com/apache/lucene/pull/12667#issuecomment-1761727033
> The jdk.incubator.vector must be removed from the module-info.java file.
This was intentional, otherwise the example benchmark wouldn't compile...
But since the vectors-specific c
dweiss commented on PR #12667:
URL: https://github.com/apache/lucene/pull/12667#issuecomment-1761724093
> is it enough to have RUNTIME_JAVA_HOME set when using Gradle to run
benchmark with also preview versions not yet supported by Gradle?
The code will compile with the provided RUNTI
uschindler commented on PR #12667:
URL: https://github.com/apache/lucene/pull/12667#issuecomment-1761718313
Fixed. If you start the benchamrk now in module mode with the command line
provided by "assemble" it works correct:
```
> Task :lucene:benchmark-jmh:assemble
JMH bench
dweiss commented on code in PR #12667:
URL: https://github.com/apache/lucene/pull/12667#discussion_r1358421683
##
help/jmh.txt:
##
@@ -0,0 +1,15 @@
+benchmarks
+==
+
+See the README.txt folder in lucene/benchmark-jmh for how to run benchmarks
using the build system.
Re
uschindler commented on PR #12667:
URL: https://github.com/apache/lucene/pull/12667#issuecomment-1761713255
Let me fix...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
dweiss commented on PR #12667:
URL: https://github.com/apache/lucene/pull/12667#issuecomment-1761712726
> ./gradlew :lucene:benchmark-jmh:run, which runs with the main gradle or
alternative JDK as configured in Gradle.
I mentioned this on the original issue - I don't think forking a J
uschindler commented on PR #12667:
URL: https://github.com/apache/lucene/pull/12667#issuecomment-1761684636
I just committed the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
uschindler commented on PR #12667:
URL: https://github.com/apache/lucene/pull/12667#issuecomment-1761682258
Sorry for the chaotic comments, the `failOnMissingClasses = false` line can
be removed.
I checked it with roberts branch:
```
> Task :lucene:benchmark-jmh:forbiddenApisMai
uschindler commented on PR #12667:
URL: https://github.com/apache/lucene/pull/12667#issuecomment-1761668041
> > Hi Robert, could you remove this exclusion:
https://github.com/dweiss/lucene/blob/e2e1b569fba1593ff4c3381f3494f552db2b4c74/lucene/benchmark-jmh/build.gradle#L37-L38
> > It is no
rmuir commented on PR #12667:
URL: https://github.com/apache/lucene/pull/12667#issuecomment-1761663375
> Hi Robert, could you remove this exclusion:
https://github.com/dweiss/lucene/blob/e2e1b569fba1593ff4c3381f3494f552db2b4c74/lucene/benchmark-jmh/build.gradle#L37-L38
>
> It is no lo
uschindler commented on PR #12667:
URL: https://github.com/apache/lucene/pull/12667#issuecomment-1761642871
> @dweiss is it enough to have RUNTIME_JAVA_HOME set when using Gradle to
run benchmark with also preview versions not yet supported by Gradle?
I noticed you need to run it on y
uschindler commented on PR #12667:
URL: https://github.com/apache/lucene/pull/12667#issuecomment-1761613992
Hi Robert,
could you remove this exclusion:
https://github.com/dweiss/lucene/blob/e2e1b569fba1593ff4c3381f3494f552db2b4c74/lucene/benchmark-jmh/build.gradle#L37-L38
It is
rmuir commented on PR #12667:
URL: https://github.com/apache/lucene/pull/12667#issuecomment-1761582752
I updated the docs, please have another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
rmuir commented on code in PR #12667:
URL: https://github.com/apache/lucene/pull/12667#discussion_r1358317343
##
lucene/benchmark-jmh/README.txt:
##
@@ -15,15 +15,16 @@ java --module-path lucene\benchmark-jmh\build\benchmarks
--module org.apache.luc
You can pass any JMH opti
ChrisHegarty commented on code in PR #12667:
URL: https://github.com/apache/lucene/pull/12667#discussion_r1358302452
##
lucene/benchmark-jmh/README.txt:
##
@@ -15,15 +15,16 @@ java --module-path lucene\benchmark-jmh\build\benchmarks
--module org.apache.luc
You can pass any J
ChrisHegarty commented on code in PR #12667:
URL: https://github.com/apache/lucene/pull/12667#discussion_r1358302452
##
lucene/benchmark-jmh/README.txt:
##
@@ -15,15 +15,16 @@ java --module-path lucene\benchmark-jmh\build\benchmarks
--module org.apache.luc
You can pass any J
rmuir commented on PR #12667:
URL: https://github.com/apache/lucene/pull/12667#issuecomment-1761564948
I also removed some of the hacky self-tests the benchmarks were doing
(comparing results across different impls). The reason is: when experimenting,
you can easily validate the correctness
ChrisHegarty commented on PR #12667:
URL: https://github.com/apache/lucene/pull/12667#issuecomment-1761486768
This looks great. I'll checkout the branch and play a little with, then
report back.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
rmuir commented on code in PR #12667:
URL: https://github.com/apache/lucene/pull/12667#discussion_r1358163111
##
help/jmh.txt:
##
@@ -0,0 +1,15 @@
+benchmarks
+==
+
+See the README.txt folder in lucene/benchmark-jmh for how to run benchmarks
using the build system.
Rev
dweiss commented on code in PR #12667:
URL: https://github.com/apache/lucene/pull/12667#discussion_r1358126818
##
help/jmh.txt:
##
@@ -0,0 +1,15 @@
+benchmarks
+==
+
+See the README.txt folder in lucene/benchmark-jmh for how to run benchmarks
using the build system.
Re
uschindler commented on PR #12667:
URL: https://github.com/apache/lucene/pull/12667#issuecomment-1761054475
I have not yet checked the benchmakr fraework at all (earlier PR), but the
idea here is cool:
--
This is an automated message from the Apache Git Service.
To respond to the mess
rmuir commented on PR #12667:
URL: https://github.com/apache/lucene/pull/12667#issuecomment-1760526957
You can still tell what's happening too due to the log messages. When each
benchmark runs, you see a single message:
xxxScalar() methods:
```
WARNING: Java vector incubator mod
rmuir opened a new pull request, #12667:
URL: https://github.com/apache/lucene/pull/12667
Following up to @dweiss work, this gives us the same benchmarks as
https://github.com/rmuir/vectorbench, just without the code duplication and
maintenance hassle.
Each method is simply invoked w
32 matches
Mail list logo
