ChrisHegarty commented on code in PR #12667:
URL: https://github.com/apache/lucene/pull/12667#discussion_r1358302452


##########
lucene/benchmark-jmh/README.txt:
##########
@@ -15,15 +15,16 @@ java --module-path lucene\benchmark-jmh\build\benchmarks 
--module org.apache.luc
 
 You can pass any JMH options to the above command, for example:
 
-  -h      displays verbose help for all options
-  -l      list available benchmarks
-  -lp     list benchmarks that pass the filter and their parameters
-  regexp  execute all benchmark containing regexp
+  -h               displays verbose help for all options
+  -l               list available benchmarks
+  -lp              list benchmarks that pass the filter and their parameters
+  -prof perfasm    use perfasm profiler to see assembly
+  regexp           execute all benchmark containing regexp
 
 Here is an example running a single benchmark:
 
-java --module-path lucene\benchmark-jmh\build\benchmarks --module 
org.apache.lucene.benchmark.jmh 
org.apache.lucene.benchmark.jmh.BinaryCosineBenchmark.cosineDistanceNew
+java --module-path lucene\benchmark-jmh\build\benchmarks --module 
org.apache.lucene.benchmark.jmh 
org.apache.lucene.benchmark.jmh.VectorUtilBenchmark.binaryCosineVector
 
-Or running all of BinaryCosineBenchmark
+Or running all of VectorUtilBenchmark
 
-java --module-path lucene\benchmark-jmh\build\benchmarks --module 
org.apache.lucene.benchmark.jmh 
org.apache.lucene.benchmark.jmh.BinaryCosineBenchmark
\ No newline at end of file
+java --module-path lucene\benchmark-jmh\build\benchmarks --module 
org.apache.lucene.benchmark.jmh 
org.apache.lucene.benchmark.jmh.VectorUtilBenchmark

Review Comment:
   hmm.. I had to replace these backslashes with forward slash !



##########
lucene/benchmark-jmh/README.txt:
##########
@@ -15,15 +15,16 @@ java --module-path lucene\benchmark-jmh\build\benchmarks 
--module org.apache.luc
 
 You can pass any JMH options to the above command, for example:
 
-  -h      displays verbose help for all options
-  -l      list available benchmarks
-  -lp     list benchmarks that pass the filter and their parameters
-  regexp  execute all benchmark containing regexp
+  -h               displays verbose help for all options
+  -l               list available benchmarks
+  -lp              list benchmarks that pass the filter and their parameters
+  -prof perfasm    use perfasm profiler to see assembly
+  regexp           execute all benchmark containing regexp
 
 Here is an example running a single benchmark:
 
-java --module-path lucene\benchmark-jmh\build\benchmarks --module 
org.apache.lucene.benchmark.jmh 
org.apache.lucene.benchmark.jmh.BinaryCosineBenchmark.cosineDistanceNew
+java --module-path lucene\benchmark-jmh\build\benchmarks --module 
org.apache.lucene.benchmark.jmh 
org.apache.lucene.benchmark.jmh.VectorUtilBenchmark.binaryCosineVector

Review Comment:
   Trivially, I'd be tempted to use a comparative example, e.g.
   
   `... org.apache.lucene.benchmark.jmh.VectorUtilBenchmark.binaryCosine.* 
-psize=1024`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to