rmuir commented on PR #12667: URL: https://github.com/apache/lucene/pull/12667#issuecomment-1761564948
I also removed some of the hacky self-tests the benchmarks were doing (comparing results across different impls). The reason is: when experimenting, you can easily validate the correctness with `gradlew test` now that it sits under the same umbrella. It was a hack due to the cost of copy-paste between two different git repositories and stuff like that. I figure: let's keep the benchmarks simple and focused on benchmarking and stable results. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
