Re: [PR] errorprone-improvements [lucene]

2025-02-07 Thread via GitHub
risdenk commented on code in PR #14216: URL: https://github.com/apache/lucene/pull/14216#discussion_r1947419244 ## gradle/validation/error-prone.gradle: ## @@ -429,6 +508,8 @@ allprojects { prj -> '-Xep:OverrideThrowableToString:WARN', '-Xep:Overrides:W

Re: [PR] errorprone-improvements [lucene]

2025-02-07 Thread via GitHub
risdenk commented on code in PR #14216: URL: https://github.com/apache/lucene/pull/14216#discussion_r1947419192 ## gradle/validation/error-prone.gradle: ## @@ -381,43 +445,58 @@ allprojects { prj -> // '-Xep:JodaPlusMinusLong:OFF', // we don't use joda-time

Re: [PR] errorprone-improvements [lucene]

2025-02-07 Thread via GitHub
risdenk commented on code in PR #14216: URL: https://github.com/apache/lucene/pull/14216#discussion_r1947419002 ## gradle/validation/error-prone.gradle: ## @@ -65,6 +65,50 @@ allprojects { prj -> return } +// Exclude certain files (generated ones, m

Re: [PR] errorprone-improvements [lucene]

2025-02-07 Thread via GitHub
risdenk commented on code in PR #14216: URL: https://github.com/apache/lucene/pull/14216#discussion_r1947418244 ## lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseSegmentInfoFormatTestCase.java: ## @@ -391,11 +391,7 @@ public void testSort() throws IOException {

[PR] errorprone-improvements [lucene]

2025-02-07 Thread via GitHub
risdenk opened a new pull request, #14216: URL: https://github.com/apache/lucene/pull/14216 ### Description Builds on top of https://github.com/apache/lucene/pull/14201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu