risdenk commented on code in PR #14216: URL: https://github.com/apache/lucene/pull/14216#discussion_r1947419244
########## gradle/validation/error-prone.gradle: ########## @@ -429,6 +508,8 @@ allprojects { prj -> '-Xep:OverrideThrowableToString:WARN', '-Xep:Overrides:WARN', // '-Xep:OverridesGuiceInjectableMethod:OFF', // we don't use guice + '-Xep:OverridingMethodInconsistentArgumentNamesChecker:WARN', + '-Xep:PatternMatchingInstanceof:WARN', Review Comment: This is where a majority of the changes come from. I do think it makes things a lot clearer, but am happy to revert this change too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org