risdenk commented on code in PR #14216:
URL: https://github.com/apache/lucene/pull/14216#discussion_r1947419192
##########
gradle/validation/error-prone.gradle:
##########
@@ -381,43 +445,58 @@ allprojects { prj ->
// '-Xep:JodaPlusMinusLong:OFF', // we don't use joda-time
// '-Xep:JodaTimeConverterManager:OFF', // we don't use joda-time
// '-Xep:JodaWithDurationAddedLong:OFF', // we don't use joda-time
+ '-Xep:JUnitIncompatibleType:WARN',
// '-Xep:LabelledBreakTarget:OFF', // stylistic
// '-Xep:LiteEnumValueOf:OFF', // we don't use protobuf
// '-Xep:LiteProtoToString:OFF', // we don't use protobuf
// '-Xep:LockNotBeforeTry:OFF', // TODO: there are problems
+ // '-Xep:LockOnNonEnclosingClassLiteral:OFF', // TODO: there are
problems
'-Xep:LogicalAssignment:WARN',
'-Xep:LongDoubleConversion:WARN',
'-Xep:LongFloatConversion:WARN',
'-Xep:LoopOverCharArray:WARN',
'-Xep:MalformedInlineTag:WARN',
// '-Xep:MathAbsoluteNegative:OFF', // TODO: there are problems
// '-Xep:MemoizeConstantVisitorStateLookups:OFF', // we don't use
this class
+ // '-Xep:MisformattedTestData:OFF', // stylistic
// '-Xep:MissingCasesInEnumSwitch:OFF', // redundant with ECJ
incompleteEnumSwitch/missingEnumCaseDespiteDefault
// '-Xep:MissingFail:OFF', // TODO: there are problems
'-Xep:MissingImplementsComparable:WARN',
// '-Xep:MissingOverride:OFF', // ECJ takes care of this
+ // '-Xep:MissingRefasterAnnotation:OFF', // we don't use this
annotation
// '-Xep:MissingSummary:OFF', // TODO: there are problems
// '-Xep:MixedMutabilityReturnType:OFF', // noisy
+ // '-Xep:MockitoDoSetup:OFF', // we don't use mocking libraries
// '-Xep:MockNotUsedInProduction:OFF', // we don't use mocking
libraries
// '-Xep:ModifiedButNotUsed:OFF', // TODO: there are problems
'-Xep:ModifyCollectionInEnhancedForLoop:WARN',
'-Xep:ModifySourceCollectionInStream:WARN',
+ '-Xep:MultimapKeys:WARN',
+ // '-Xep:MultipleNullnessAnnotations:OFF', // we don't use these
annotations
'-Xep:MultipleParallelOrSequentialCalls:WARN',
'-Xep:MultipleUnaryOperatorsInMethodCall:WARN',
+ // '-Xep:MutableGuiceModule:OFF', // we don't use guice
// '-Xep:MutablePublicArray:OFF', // TODO: there are problems
+ '-Xep:NamedLikeContextualKeyword:WARN',
'-Xep:NarrowCalculation:WARN',
// '-Xep:NarrowingCompoundAssignment:OFF', // noisy
'-Xep:NegativeCharLiteral:WARN',
'-Xep:NestedInstanceOfConditions:WARN',
// '-Xep:NewFileSystem:OFF', // we don't create new filesystems
+ // '-Xep:NonApiType:OFF', // noisy
// '-Xep:NonAtomicVolatileUpdate:OFF', // TODO: there are problems
// '-Xep:NonCanonicalType:OFF', // noisy
+ // '-Xep:NonFinalStaticField:OFF', // noisy
'-Xep:NonOverridingEquals:WARN',
+ '-Xep:NotJavadoc:WARN',
Review Comment:
This is where all the `/**` to `/*` comes from
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
