gsmiller commented on PR #12880:
URL: https://github.com/apache/lucene/pull/12880#issuecomment-1850668550
Went ahead and merged this on to main/branch_9x since I saw some support for
this and no real blocking concerns.
--
This is an automated message from the Apache Git Service.
To respon
gsmiller merged PR #12880:
URL: https://github.com/apache/lucene/pull/12880
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.ap
mikemccand commented on PR #12880:
URL: https://github.com/apache/lucene/pull/12880#issuecomment-1845055537
+1 to clean these up, and open a follow-on issue to find some way to
statically detect / remove these redundant modifiers. As long as we backport
this to 9.x it should not make futur
shubhamvishu commented on PR #12880:
URL: https://github.com/apache/lucene/pull/12880#issuecomment-1844826409
Thanks @gsmiller @dweiss for taking a look. I see some great points raised
here by both of you(and I agree to all). A couple of points why I think we
should go with this change :
dweiss commented on PR #12880:
URL: https://github.com/apache/lucene/pull/12880#issuecomment-1843774013
I don't think we have any conventions for this. And I don't know if tools
can automate this.
I remember reading a thread somewhere on the openjdk mailing list that
touched on a si
gsmiller commented on PR #12880:
URL: https://github.com/apache/lucene/pull/12880#issuecomment-1843430023
Thanks @shubhamvishu! I personally like this cleanup, but I'd be curious if
others have some reasons I'm not aware of why they may prefer differently?
Maybe more importantly though, I w
shubhamvishu opened a new pull request, #12880:
URL: https://github.com/apache/lucene/pull/12880
### Description
This PR removes(or cleans up) some of the redundant modifiers from the code.
Addresses the below warning in my IDE :
- Modifier ‘static’ is redundant for inner inter
