dweiss commented on PR #12880: URL: https://github.com/apache/lucene/pull/12880#issuecomment-1843774013
I don't think we have any conventions for this. And I don't know if tools can automate this. I remember reading a thread somewhere on the openjdk mailing list that touched on a similar topic - whether to "clean up" existing codebase now that IDEs have an absolute knowledge of all language quirks. The response was: it's not necessarily a great idea - makes backporting to historical branches more difficult, makes reading the code more difficult for people not _that_ familiar with the language spec... and there's the human factor - I personally prefer to have "public static" redundancy in interface definitions, even if it's not required. I don't have a strong opinion though, we may clean this up - I don't mind./ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
