gsmiller commented on PR #12880: URL: https://github.com/apache/lucene/pull/12880#issuecomment-1843430023
Thanks @shubhamvishu! I personally like this cleanup, but I'd be curious if others have some reasons I'm not aware of why they may prefer differently? Maybe more importantly though, I wonder what this looks like going forward. It's fine to do a cleanup now, but will these things creep back in? It would be nice if a tool like "spotless" could handle this automatically (assuming the community agrees with the convention), but I'm not sure if it's capable of that. As for this one-off cleanup, I'm fine with it but would like to leave it open for a couple days to see if others have more general issues with these changes. Things our IDEs flag don't always align 100% with our conventions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
