[PR] Remove slices creation overhead from IndexSearcher constructor [lucene]

javanna opened a new pull request, #14428: URL: https://github.com/apache/lucene/pull/14428 We simplified the slices creation in IndexSearcher with #13893. That removed the need for a caching supplier, but had an unexpected effect: we eagerly create slices now for the case where no executor

Re: [PR] Remove slices creation overhead from IndexSearcher constructor [lucene]

jainankitk commented on code in PR #14428: URL: https://github.com/apache/lucene/pull/14428#discussion_r2026306457 ## lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java: ## @@ -223,12 +223,6 @@ public IndexSearcher(IndexReaderContext context, Executor executor) {

Re: [PR] Remove slices creation overhead from IndexSearcher constructor [lucene]

jainankitk commented on code in PR #14428: URL: https://github.com/apache/lucene/pull/14428#discussion_r2027340846 ## lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java: ## @@ -223,12 +223,6 @@ public IndexSearcher(IndexReaderContext context, Executor executor) {

Re: [PR] Remove slices creation overhead from IndexSearcher constructor [lucene]

javanna commented on code in PR #14428: URL: https://github.com/apache/lucene/pull/14428#discussion_r2026397746 ## lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java: ## @@ -223,12 +223,6 @@ public IndexSearcher(IndexReaderContext context, Executor executor) {