Re: [PR] Remove obsolete 'mappingRules' in Tokenizer tests [lucene]

2024-01-08 Thread via GitHub
dweiss commented on code in PR #12972: URL: https://github.com/apache/lucene/pull/12972#discussion_r140905 ## lucene/analysis/common/src/test/org/apache/lucene/analysis/wikipedia/TestWikipediaTokenizerFactory.java: ## @@ -145,19 +140,17 @@ public void testBogusArguments() th

Re: [PR] Remove obsolete 'mappingRules' in Tokenizer tests [lucene]

2024-01-08 Thread via GitHub
dweiss commented on code in PR #12972: URL: https://github.com/apache/lucene/pull/12972#discussion_r140905 ## lucene/analysis/common/src/test/org/apache/lucene/analysis/wikipedia/TestWikipediaTokenizerFactory.java: ## @@ -145,19 +140,17 @@ public void testBogusArguments() th

Re: [PR] Remove obsolete 'mappingRules' in Tokenizer tests [lucene]

2024-01-08 Thread via GitHub
sabi0 commented on code in PR #12972: URL: https://github.com/apache/lucene/pull/12972#discussion_r1444282486 ## lucene/analysis/common/src/test/org/apache/lucene/analysis/wikipedia/TestWikipediaTokenizerFactory.java: ## @@ -145,19 +140,17 @@ public void testBogusArguments() thr

Re: [PR] Remove obsolete 'mappingRules' in Tokenizer tests [lucene]

2023-12-30 Thread via GitHub
dweiss merged PR #12972: URL: https://github.com/apache/lucene/pull/12972 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

Re: [PR] Remove obsolete 'mappingRules' in Tokenizer tests [lucene]

2023-12-30 Thread via GitHub
dweiss commented on code in PR #12972: URL: https://github.com/apache/lucene/pull/12972#discussion_r1438639789 ## lucene/analysis/common/src/test/org/apache/lucene/analysis/wikipedia/TestWikipediaTokenizerFactory.java: ## @@ -145,19 +140,17 @@ public void testBogusArguments() th

[PR] Remove obsolete 'mappingRules' in Tokenizer tests [lucene]

2023-12-24 Thread via GitHub
sabi0 opened a new pull request, #12972: URL: https://github.com/apache/lucene/pull/12972 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai