dweiss commented on code in PR #12972:
URL: https://github.com/apache/lucene/pull/12972#discussion_r1438639789
##########
lucene/analysis/common/src/test/org/apache/lucene/analysis/wikipedia/TestWikipediaTokenizerFactory.java:
##########
@@ -145,19 +140,17 @@ public void testBogusArguments() throws Exception {
IllegalArgumentException expected =
expectThrows(
IllegalArgumentException.class,
- () -> {
- tokenizerFactory(WIKIPEDIA, "bogusArg",
"bogusValue").create(newAttributeFactory());
- });
+ () ->
+ tokenizerFactory(WIKIPEDIA, "bogusArg", "bogusValue")
+ .create(newAttributeFactory()));
assertTrue(expected.getMessage().contains("Unknown parameters"));
}
public void testIllegalArguments() throws Exception {
IllegalArgumentException expected =
expectThrows(
IllegalArgumentException.class,
- () -> {
Review Comment:
Sometimes those extra brackets make the code easier to read. Please avoid to
urge to just apply
everything intellij says can be "fixed". In this case (and the one above),
I'd pick the bracketed version - easier on the eyes, especially after the code
is tidied up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
