dweiss commented on code in PR #12972:
URL: https://github.com/apache/lucene/pull/12972#discussion_r1444440905
##########
lucene/analysis/common/src/test/org/apache/lucene/analysis/wikipedia/TestWikipediaTokenizerFactory.java:
##########
@@ -145,19 +140,17 @@ public void testBogusArguments() throws Exception {
IllegalArgumentException expected =
expectThrows(
IllegalArgumentException.class,
- () -> {
- tokenizerFactory(WIKIPEDIA, "bogusArg",
"bogusValue").create(newAttributeFactory());
- });
+ () ->
+ tokenizerFactory(WIKIPEDIA, "bogusArg", "bogusValue")
+ .create(newAttributeFactory()));
assertTrue(expected.getMessage().contains("Unknown parameters"));
}
public void testIllegalArguments() throws Exception {
IllegalArgumentException expected =
expectThrows(
IllegalArgumentException.class,
- () -> {
Review Comment:
> I try to be rather picky about anything IntelliJ says.
It's a very useful tool. But I wouldn't apply them automatically - many of
the refactorings it suggests are subjective (whoever devised their code
inspections was a human, after all). They're occasionally also wrong,
introducing bugs - I've had that more than one time in my life (escape or
visibility analysis gone wrong, for example).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
