easyice closed pull request #13171: Reduce some unnecessary ArrayUtil#grow calls
URL: https://github.com/apache/lucene/pull/13171
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
stefanvodita commented on PR #13171:
URL: https://github.com/apache/lucene/pull/13171#issuecomment-2018978359
Thanks for the explanation! The way I think about it is whether it would be
ok to make this check every time we call `grow`. Probably not, it's nice that
`grow` does the check for y
easyice commented on PR #13171:
URL: https://github.com/apache/lucene/pull/13171#issuecomment-2018304676
@stefanvodita Thank you for looking into this! when an array does not need
to grow, The `ArrayUtil.grow` will return the input `array`, then it will call
an extra assignment like `ref.b
stefanvodita commented on PR #13171:
URL: https://github.com/apache/lucene/pull/13171#issuecomment-2017455119
@easyice - I'm probably missing something obvious, but I thought
`ArrayUtil.grow` already made the same check. Can you explain why this PR helps?
https://github.com/apache/lucene
github-actions[bot] commented on PR #13171:
URL: https://github.com/apache/lucene/pull/13171#issuecomment-2016641599
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
