stefanvodita commented on PR #13171: URL: https://github.com/apache/lucene/pull/13171#issuecomment-2018978359
Thanks for the explanation! The way I think about it is whether it would be ok to make this check every time we call `grow`. Probably not, it's nice that `grow` does the check for you. Maybe simplicity is worth more than the performance gain here? If you think the performance win is compelling, I won't argue against it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org