easyice commented on PR #13171: URL: https://github.com/apache/lucene/pull/13171#issuecomment-2018304676
@stefanvodita Thank you for looking into this! when an array does not need to grow, The `ArrayUtil.grow` will return the input `array`, then it will call an extra assignment like `ref.bytes = ref.bytes` in `BytesRefBuilder#grow`. I observed there was some performance impact, which was noticeable in the `append` method. Maybe i'm being overly picky, Overall, it doesn't have a significant impact on performance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
