shubhamvishu closed pull request #12671: Move private static classes or
functions out of DoubleValuesSource
URL: https://github.com/apache/lucene/pull/12671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
shubhamvishu commented on PR #12671:
URL: https://github.com/apache/lucene/pull/12671#issuecomment-1768664812
Thanks @gsmiller and @msokolov for sharing your views. I agree with your
points and at this point this refactoring doesn't seem to provide much value,
so I think we should just leav
msokolov commented on PR #12671:
URL: https://github.com/apache/lucene/pull/12671#issuecomment-1768298204
I think I share Greg's reluctance to make this big-looking change. Sorry, I
think I was the instigator with the comment you referenced above. I confess I
have always been confused that
gsmiller commented on PR #12671:
URL: https://github.com/apache/lucene/pull/12671#issuecomment-1767291109
Thanks for your further thoughts @shubhamvishu. Getting more opinions is
always good, and like I said, I don't feel strongly enough about this change to
block moving forward with it or
shubhamvishu commented on code in PR #12671:
URL: https://github.com/apache/lucene/pull/12671#discussion_r1359519018
##
lucene/core/src/java/org/apache/lucene/search/DoubleValuesSource.java:
##
@@ -43,6 +40,9 @@
* {@link #fromScorer(Scorable)} and passing the resulting DoubleV
shubhamvishu commented on PR #12671:
URL: https://github.com/apache/lucene/pull/12671#issuecomment-1763076574
Thanks @gsmiller for the review! My motivation behind this refactoring was
[this
comment](https://github.com/apache/lucene/pull/12548#discussion_r1357027508)
from Mike which indica
gsmiller commented on code in PR #12671:
URL: https://github.com/apache/lucene/pull/12671#discussion_r1359402306
##
lucene/core/src/java/org/apache/lucene/search/VectorSimilarityValuesSource.java:
##
@@ -32,6 +33,52 @@ public VectorSimilarityValuesSource(String fieldName) {
shubhamvishu opened a new pull request, #12671:
URL: https://github.com/apache/lucene/pull/12671
### Description
This is a followup PR of #12548
Changes in this PR :
- Move some of the private static classes or functions etc out of
`DoubleValuesSource` class to keep
