shubhamvishu commented on code in PR #12671: URL: https://github.com/apache/lucene/pull/12671#discussion_r1359519018
########## lucene/core/src/java/org/apache/lucene/search/DoubleValuesSource.java: ########## @@ -43,6 +40,9 @@ * {@link #fromScorer(Scorable)} and passing the resulting DoubleValues to {@link * #getValues(LeafReaderContext, DoubleValues)}. The scores can then be accessed using the {@link * #SCORES} DoubleValuesSource. + * + * <p>Also see {@link DoubleValuesSourceUtil} class that provides some concrete implementations of Review Comment: Right, thats the intention. I kept in the javadoc thinking it might help the user to see some specific DVS implementations and maybe also reuse if required (eg : `ConstantValuesSource`). But if it might create any confusion I would instead like to remove this completely. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org