gsmiller commented on PR #12671: URL: https://github.com/apache/lucene/pull/12671#issuecomment-1767291109
Thanks for your further thoughts @shubhamvishu. Getting more opinions is always good, and like I said, I don't feel strongly enough about this change to block moving forward with it or anything if others think it's a helpful thing to do. My thoughts remain though that: 1. At least to me personally, I don't necessarily find any readability improvements from separating the public API from the definitions in this way. I don't think it's particularly challenging to navigate this one file (in fact, I personally prefer it in a number of ways). But again, this is just opinion. It's sort of the "if it's not broke, don't fix it" thing I suppose from my point of view. 2. In terms of future extensibility, my opinion is to wait until there is a real use-case driving the need to break these things out rather than move code around just in case we want to use it in more places some day. Again though, this is all pretty subjective, so if others like the change, let's go for it! I appreciate you thinking about it and looking for ways to improve things! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
