magibney commented on PR #13555:
URL: https://github.com/apache/lucene/pull/13555#issuecomment-2228844256
Closing in favor of #13570
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
magibney closed pull request #13555: Group memory arenas by segment to reduce
costly `Arena.close()`
URL: https://github.com/apache/lucene/pull/13555
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ChrisHegarty commented on PR #13555:
URL: https://github.com/apache/lucene/pull/13555#issuecomment-2227465099
Hi, I don't have access to commit to this branch, so (sorry) I just
created an alternative PR to sketch out an idea around a simplification of ref
counting the arena. See #13570
magibney commented on PR #13555:
URL: https://github.com/apache/lucene/pull/13555#issuecomment-2223189418
Thanks for the suggestions! Most of these are now addressed (with a couple
of questions: 1. maybe still need chm.computeIfAbsent() loop, 2. which if any
Arena methods to throw UOE).
magibney commented on code in PR #13555:
URL: https://github.com/apache/lucene/pull/13555#discussion_r1674172898
##
lucene/core/src/java21/org/apache/lucene/store/GroupedArena.java:
##
@@ -0,0 +1,212 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
magibney commented on code in PR #13555:
URL: https://github.com/apache/lucene/pull/13555#discussion_r1674096237
##
lucene/core/src/java21/org/apache/lucene/store/GroupedArena.java:
##
@@ -0,0 +1,212 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
uschindler commented on code in PR #13555:
URL: https://github.com/apache/lucene/pull/13555#discussion_r1673613242
##
lucene/core/src/java21/org/apache/lucene/store/MemorySegmentIndexInputProvider.java:
##
@@ -24,12 +24,15 @@
import java.nio.file.Path;
import java.nio.file.Sta
uschindler commented on code in PR #13555:
URL: https://github.com/apache/lucene/pull/13555#discussion_r1673613242
##
lucene/core/src/java21/org/apache/lucene/store/MemorySegmentIndexInputProvider.java:
##
@@ -24,12 +24,15 @@
import java.nio.file.Path;
import java.nio.file.Sta
ChrisHegarty commented on code in PR #13555:
URL: https://github.com/apache/lucene/pull/13555#discussion_r1673550548
##
lucene/core/src/java21/org/apache/lucene/store/MemorySegmentIndexInputProvider.java:
##
@@ -24,12 +24,15 @@
import java.nio.file.Path;
import java.nio.file.S
ChrisHegarty commented on code in PR #13555:
URL: https://github.com/apache/lucene/pull/13555#discussion_r1673543647
##
lucene/core/src/java21/org/apache/lucene/store/GroupedArena.java:
##
@@ -0,0 +1,212 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
uschindler commented on code in PR #13555:
URL: https://github.com/apache/lucene/pull/13555#discussion_r1672768505
##
lucene/core/src/java21/org/apache/lucene/store/GroupedArena.java:
##
@@ -0,0 +1,212 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
magibney commented on PR #13555:
URL: https://github.com/apache/lucene/pull/13555#issuecomment-2218482093
Follows an approach analogous to the ["custom
arenas"](https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/lang/foreign/Arena.html#custom-arenas)
case described in Arena j
12 matches
Mail list logo
