ChrisHegarty commented on code in PR #13555:
URL: https://github.com/apache/lucene/pull/13555#discussion_r1673550548
##########
lucene/core/src/java21/org/apache/lucene/store/MemorySegmentIndexInputProvider.java:
##########
@@ -24,12 +24,15 @@
import java.nio.file.Path;
import java.nio.file.StandardOpenOption;
import java.util.Optional;
+import java.util.concurrent.ConcurrentHashMap;
import org.apache.lucene.util.Constants;
import org.apache.lucene.util.Unwrappable;
@SuppressWarnings("preview")
final class MemorySegmentIndexInputProvider implements
MMapDirectory.MMapIndexInputProvider {
+ private static final ConcurrentHashMap<String, GroupedArena> ARENAS = new
ConcurrentHashMap<>();
Review Comment:
yes, let's make this an instance field on MMapDirectory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]