magibney commented on PR #13555:
URL: https://github.com/apache/lucene/pull/13555#issuecomment-2223189418
Thanks for the suggestions! Most of these are now addressed (with a couple
of questions: 1. maybe still need chm.computeIfAbsent() loop, 2. which if any
Arena methods to throw UOE).
I also wanted to call attention to another concern that occurred to me,
described in a comment:
```java
// TODO: what if the associated Directory is used for some purpose
other than Lucene
// index files, and some of the filenames happen to be patterned so
that a "segment"
// can be parsed from them? That could result in files being
spuriously grouped
// together in the same arena. This would only practically be a
problem if such a
// "segment" was never closed (refCt never 0), _and_ enough files
associated with that
// "segment" were opened and closed (without ever closing the
associated Arena)
// to exhaust virtual memory space.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
