Re: [PR] Fix points writing with no values [lucene]

2024-05-16 Thread via GitHub
ChrisHegarty merged PR #13378: URL: https://github.com/apache/lucene/pull/13378 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucen

Re: [PR] Fix points writing with no values [lucene]

2024-05-16 Thread via GitHub
ChrisHegarty commented on PR #13378: URL: https://github.com/apache/lucene/pull/13378#issuecomment-2115197055 > Thanks, the fix looks good to me. This makes me want to also improve the test from #13369 to add an `assertNull(onlyReader.getPointValues("field"));`, could you do it as part of t

[PR] Fix points writing with no values [lucene]

2024-05-16 Thread via GitHub
ChrisHegarty opened a new pull request, #13378: URL: https://github.com/apache/lucene/pull/13378 This commit updates the writer to handle the case where there are no values. Previously (before #13369), there was a check that there were some points values before trying to write, this i