ChrisHegarty commented on PR #13378:
URL: https://github.com/apache/lucene/pull/13378#issuecomment-2115197055
> Thanks, the fix looks good to me. This makes me want to also improve the
test from #13369 to add an `assertNull(onlyReader.getPointValues("field"));`,
could you do it as part of this PR? The connection with your PR is that we're
not writing empty fields, so getting a `PointValues` instance should return
`null`, not an empty instance.
++ that makes sense. Nice to assert this. Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
