ChrisHegarty opened a new pull request, #13378: URL: https://github.com/apache/lucene/pull/13378
This commit updates the writer to handle the case where there are no values. Previously (before #13369), there was a check that there were some points values before trying to write, this is no longer the case. The code in `writeFieldNDims` has an assumption that the values is not empty - an empty values will result in calculating a negative number of splits, and a negate array size to hold the splits. The fix is is trivial, return null when values is empty - null is an allowable return value from this method. Note: `writeField1Dim` is able to handle an empty values. After this change both the newly failing test, `TestIndexWriterExceptions2.testBasics`, and the test added for #13369, `testExceptionJustBeforeFlushWithPointValues`, pass successfully several thousands of times. closes #13377 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
