cinsttool commented on code in PR #13254:
URL: https://github.com/apache/lucene/pull/13254#discussion_r1547605381
##
lucene/core/src/java/org/apache/lucene/index/FieldInfos.java:
##
@@ -165,8 +164,7 @@ public FieldInfos(FieldInfo[] infos) {
valuesTemp.add(byNumberTemp[i
jpountz commented on code in PR #13254:
URL: https://github.com/apache/lucene/pull/13254#discussion_r1547438514
##
lucene/core/src/java/org/apache/lucene/index/FieldInfos.java:
##
@@ -165,8 +164,7 @@ public FieldInfos(FieldInfo[] infos) {
valuesTemp.add(byNumberTemp[i])
cinsttool commented on code in PR #13254:
URL: https://github.com/apache/lucene/pull/13254#discussion_r1547361175
##
lucene/core/src/java/org/apache/lucene/index/FieldInfos.java:
##
@@ -165,8 +164,7 @@ public FieldInfos(FieldInfo[] infos) {
valuesTemp.add(byNumberTemp[i
cinsttool commented on code in PR #13254:
URL: https://github.com/apache/lucene/pull/13254#discussion_r1547314639
##
lucene/core/src/java/org/apache/lucene/codecs/CompetitiveImpactAccumulator.java:
##
@@ -107,26 +107,30 @@ public void copy(CompetitiveImpactAccumulator acc) {
cinsttool commented on code in PR #13254:
URL: https://github.com/apache/lucene/pull/13254#discussion_r1547314335
##
lucene/core/src/java/org/apache/lucene/index/FieldInfos.java:
##
@@ -165,8 +164,7 @@ public FieldInfos(FieldInfo[] infos) {
valuesTemp.add(byNumberTemp[i
jpountz commented on code in PR #13254:
URL: https://github.com/apache/lucene/pull/13254#discussion_r1547286138
##
lucene/core/src/java/org/apache/lucene/codecs/CompetitiveImpactAccumulator.java:
##
@@ -107,26 +107,30 @@ public void copy(CompetitiveImpactAccumulator acc) {
cinsttool opened a new pull request, #13254:
URL: https://github.com/apache/lucene/pull/13254
…Accumulator.java
### Description
Hi,
We find that there exist container inefficiencies in FieldInfos.java and
CompetitiveImpactAccumulator.java.
In particular, at line 126