cinsttool commented on code in PR #13254:
URL: https://github.com/apache/lucene/pull/13254#discussion_r1547314335
##########
lucene/core/src/java/org/apache/lucene/index/FieldInfos.java:
##########
@@ -165,8 +164,7 @@ public FieldInfos(FieldInfo[] infos) {
valuesTemp.add(byNumberTemp[i]);
}
}
- values =
-
Collections.unmodifiableCollection(Arrays.asList(valuesTemp.toArray(new
FieldInfo[0])));
+ values = Collections.unmodifiableCollection(valuesTemp);
Review Comment:
How about counting the number of non-null infos in the for loop at line 86
and converting `valuesTemp` into a fixed-size array to store them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
