cinsttool commented on code in PR #13254:
URL: https://github.com/apache/lucene/pull/13254#discussion_r1547605381
##########
lucene/core/src/java/org/apache/lucene/index/FieldInfos.java:
##########
@@ -165,8 +164,7 @@ public FieldInfos(FieldInfo[] infos) {
valuesTemp.add(byNumberTemp[i]);
}
}
- values =
-
Collections.unmodifiableCollection(Arrays.asList(valuesTemp.toArray(new
FieldInfo[0])));
+ values = Collections.unmodifiableCollection(valuesTemp);
Review Comment:
> If we pre-size `valuesTemp` correctly, it looks like it would work indeed.
We observe that the `info` will never be null since the if statements
already visit `info.number` here at line 87. Therefore, we pre-size
`valuesTemp` to `infos.length`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
