uschindler commented on PR #13095:
URL: https://github.com/apache/lucene/pull/13095#issuecomment-1944599169
Sorry, I was just irritated, because the original PR was opened against
stable branch. 😜
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
s1monw commented on PR #13095:
URL: https://github.com/apache/lucene/pull/13095#issuecomment-1944584231
@uschindler dude I need to press buttons it took me 14 mins to port I guess
that's ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
uschindler commented on PR #13095:
URL: https://github.com/apache/lucene/pull/13095#issuecomment-1944578996
This was merged to 9.x only. Should we not have it in main, too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
s1monw merged PR #13095:
URL: https://github.com/apache/lucene/pull/13095
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
s1monw commented on PR #13095:
URL: https://github.com/apache/lucene/pull/13095#issuecomment-1944559092
> P.S.: I don't know if we still need those 4 special case indexes. They
seem to be a relic from earlier times. As we only check that the indexes throw
an Exception on loading, the alread
dweiss commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1488370861
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -48,25 +53,31 @@
public abstract class BackwardsCompat
dweiss commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1488367811
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -48,25 +53,31 @@
public abstract class BackwardsCompat
uschindler commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1488362426
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -48,25 +53,31 @@
public abstract class BackwardsCo
dweiss commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1488345592
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -48,25 +52,28 @@
public abstract class BackwardsCompat
s1monw commented on PR #13095:
URL: https://github.com/apache/lucene/pull/13095#issuecomment-1941931700
@uschindler I did separate out the specific indices and added a new file.
that makes maintenance simpler and moves the `-cfs` `-nocfs` duplication to the
code. Also applied you comments.
uschindler commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1487826242
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -50,7 +52,7 @@
public abstract class BackwardsComp
uschindler commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1487821423
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -48,25 +52,28 @@
public abstract class BackwardsCo
uschindler commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1487811954
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -48,25 +52,28 @@
public abstract class BackwardsCo
uschindler commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1487803547
##
dev-tools/scripts/addBackcompatIndexes.py:
##
@@ -114,53 +113,25 @@ def find_version(x):
x = re.sub(strip_dash_suffix_re, '', x) # remove the -suffix if any
dweiss commented on PR #13095:
URL: https://github.com/apache/lucene/pull/13095#issuecomment-1941375395
I've broken it, I'll fix it in a sec.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
dweiss commented on PR #13095:
URL: https://github.com/apache/lucene/pull/13095#issuecomment-1941331344
I pushed a simple patch replacing properties with txt files - no need to
worry about property file syntax and easier to read too, I think.
I like how python script got simpler too.
s1monw commented on PR #13095:
URL: https://github.com/apache/lucene/pull/13095#issuecomment-1941123474
@uschindler @dweiss I moved all version to property files and updated the
python script
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
dweiss commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1487332805
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -47,25 +47,64 @@
public abstract class BackwardsCompat
uschindler commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1486879238
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -47,25 +47,64 @@
public abstract class BackwardsCo
uschindler commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1486879238
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -47,25 +47,64 @@
public abstract class BackwardsCo
uschindler commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1486881008
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -47,25 +47,64 @@
public abstract class BackwardsCo
uschindler commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1486879238
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -47,25 +47,64 @@
public abstract class BackwardsCo
dweiss commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1486846219
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -47,25 +47,64 @@
public abstract class BackwardsCompat
uschindler commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1486656215
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -47,25 +47,64 @@
public abstract class BackwardsCo
uschindler commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1486656215
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -47,25 +47,64 @@
public abstract class BackwardsCo
uschindler commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1486656215
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -47,25 +47,64 @@
public abstract class BackwardsCo
dweiss commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1486645486
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -47,25 +47,64 @@
public abstract class BackwardsCompat
uschindler commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1486640670
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -47,25 +47,64 @@
public abstract class BackwardsCo
uschindler commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1486637570
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -47,25 +47,64 @@
public abstract class BackwardsCo
uschindler commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1486632751
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -47,25 +47,64 @@
public abstract class BackwardsCo
uschindler commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1486628856
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -47,25 +47,64 @@
public abstract class BackwardsCo
dweiss commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1486550352
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -47,25 +47,64 @@
public abstract class BackwardsCompat
dweiss commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1486545976
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -47,25 +47,64 @@
public abstract class BackwardsCompat
uschindler commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1486539904
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -47,25 +47,64 @@
public abstract class BackwardsCo
dweiss commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1486535126
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -47,25 +47,64 @@
public abstract class BackwardsCompat
dweiss commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1486531645
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -47,25 +47,64 @@
public abstract class BackwardsCompat
jpountz commented on PR #13095:
URL: https://github.com/apache/lucene/pull/13095#issuecomment-1939072225
@uschindler I have been blindly following the release wizard, I'll look into
the failure in a bit and see how we can address it.
--
This is an automated message from the Apache Git Ser
uschindler commented on PR #13095:
URL: https://github.com/apache/lucene/pull/13095#issuecomment-1939064842
@jpountz fixed the duplicate `@Deprecated` but it still fails because it
can't find v9.11.0. I have no idea how it handles the last version of a
previous stable branch. For sure from
uschindler commented on PR #13095:
URL: https://github.com/apache/lucene/pull/13095#issuecomment-1938981480
> @uschindler i think it's because @jpountz added a new version on branch_9x
I spoke to him already I think it breaks tests as well on the stable branch
Yeah, I also see this on
s1monw commented on PR #13095:
URL: https://github.com/apache/lucene/pull/13095#issuecomment-1938967335
@uschindler i think it's because @jpountz added a new version on branch_9x I
spoke to him already I think it breaks tests as well on the stable branch
--
This is an automated messag
uschindler commented on PR #13095:
URL: https://github.com/apache/lucene/pull/13095#issuecomment-1938959760
Great! I haven't seen we use `//spotless:off` already and its enabled in the
config. So I think this is best option here. This also allows the regexes for
the script to not break sudd
s1monw commented on PR #13095:
URL: https://github.com/apache/lucene/pull/13095#issuecomment-1938895854
@uschindler this works. it's funky if one of the strings has a certain
length it will allow the bock-like strucuture.
--
This is an automated message from the Apache Git Service.
To res
uschindler commented on PR #13095:
URL: https://github.com/apache/lucene/pull/13095#issuecomment-1938869700
I'd like for the reasons described before to enable this option:
https://stackoverflow.com/a/76221803
--
This is an automated message from the Apache Git Service.
To respond t
uschindler commented on PR #13095:
URL: https://github.com/apache/lucene/pull/13095#issuecomment-1938862855
What's the exact problem with tidy?
I think after adding the new version, we should run tidy to let it cleanup
the code.
I will check if there are some comment signals to ti
s1monw commented on PR #13095:
URL: https://github.com/apache/lucene/pull/13095#issuecomment-1938803239
this fixes the release script but I can't get tidy to not wrap the array
[here](https://github.com/apache/lucene/pull/13095/files#diff-8946e557343c70aadb734c2f1bdceeed366f32c6f667ea75b89b8
s1monw opened a new pull request, #13095:
URL: https://github.com/apache/lucene/pull/13095
In #13046 several changes broke the addBackcompatIndexes.py script to
properly add and test the unreleased version. This updates the script to again
properly add the new version.
Closes #13094
46 matches
Mail list logo
