dweiss commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1486531645


##########
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##########
@@ -47,25 +47,64 @@
 
 public abstract class BackwardsCompatibilityTestBase extends LuceneTestCase {
 
-  protected final Version version;
+  // spotless:off

Review Comment:
   I don't think this is such a great idea... in general, google java format 
does not have any way to prevent formatting - it's all or nothing (this is a 
deliberate decision).
   
   I think a better way to fix this would be to:
   * read this from a resource, which can be a plain text file formatted in any 
way you like,
   * use // comments on each line to force line breaks for google java 
formatter (ugly but will work).
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to