uschindler commented on code in PR #13095: URL: https://github.com/apache/lucene/pull/13095#discussion_r1487826242
########## lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java: ########## @@ -50,7 +52,7 @@ public abstract class BackwardsCompatibilityTestBase extends LuceneTestCase { - static final String[] OLD_VERSIONS; + static final Set<String> OLD_VERSIONS; Review Comment: I think the String sets can be private, as we only want to expose the Version numbers, correct? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org