mikemccand merged PR #12786:
URL: https://github.com/apache/lucene/pull/12786
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
mikemccand commented on PR #12786:
URL: https://github.com/apache/lucene/pull/12786#issuecomment-1808651797
`Test2BFST` is happy:
```
The slowest tests (exceeding 500 ms) during this run:
mikemccand commented on code in PR #12786:
URL: https://github.com/apache/lucene/pull/12786#discussion_r1391299752
##
lucene/core/src/java/org/apache/lucene/util/fst/NodeHash.java:
##
@@ -289,21 +273,38 @@ public long getNodeAddress(long hashSlot) {
}
/**
- * Set
dungba88 commented on code in PR #12786:
URL: https://github.com/apache/lucene/pull/12786#discussion_r1387298308
##
lucene/core/src/java/org/apache/lucene/util/fst/NodeHash.java:
##
@@ -289,21 +273,38 @@ public long getNodeAddress(long hashSlot) {
}
/**
- * Set t
dungba88 commented on PR #12786:
URL: https://github.com/apache/lucene/pull/12786#issuecomment-1802854503
> Could not copy file
'/home/runner/work/lucene/lucene/lucene/JRE_VERSION_MIGRATION.md' to
'/home/runner/work/lucene/lucene/lucene/documentation/build/site/JRE_VERSION_MIGRATION.html'.
dungba88 opened a new pull request, #12786:
URL: https://github.com/apache/lucene/pull/12786
### Description
See the previous PR: https://github.com/apache/lucene/pull/12778
There was a bug in the PR, the copiedNodeAddress is the last address
(inclusively) of the node, thus the
dungba88 commented on PR #12778:
URL: https://github.com/apache/lucene/pull/12778#issuecomment-1802753207
Thank you for reproducing this! I found the bug, it's quite silly. The node
address is the last address, so I should have do this
```
copiedNodes.append(fallbackTable.cop
mikemccand commented on PR #12778:
URL: https://github.com/apache/lucene/pull/12778#issuecomment-1802219722
(And does not reproduce once I revert).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mikemccand commented on PR #12778:
URL: https://github.com/apache/lucene/pull/12778#issuecomment-1802214263
And it does reproduce for me. I'll revert this change for now!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
mikemccand commented on PR #12778:
URL: https://github.com/apache/lucene/pull/12778#issuecomment-1802213131
Hmm running `./gradlew check` after pulling this change into my dev box I
hit:
```
org.apache.lucene.util.fst.TestFSTs > test suite's output saved to
/s1/l/trunk/lucene/core
mikemccand merged PR #12778:
URL: https://github.com/apache/lucene/pull/12778
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
dungba88 commented on code in PR #12778:
URL: https://github.com/apache/lucene/pull/12778#discussion_r1386637002
##
lucene/core/src/java/org/apache/lucene/util/fst/NodeHash.java:
##
@@ -289,21 +273,34 @@ public long getNodeAddress(long hashSlot) {
}
/**
- * Set t
mikemccand commented on code in PR #12778:
URL: https://github.com/apache/lucene/pull/12778#discussion_r1386504215
##
lucene/core/src/java/org/apache/lucene/util/fst/NodeHash.java:
##
@@ -289,21 +273,34 @@ public long getNodeAddress(long hashSlot) {
}
/**
- * Set
dungba88 commented on code in PR #12778:
URL: https://github.com/apache/lucene/pull/12778#discussion_r1384749437
##
lucene/core/src/java/org/apache/lucene/util/ByteBlockPool.java:
##
@@ -234,6 +234,44 @@ public void append(final BytesRef bytes) {
append(bytes.bytes, bytes.o
mikemccand commented on code in PR #12778:
URL: https://github.com/apache/lucene/pull/12778#discussion_r1384697358
##
lucene/core/src/java/org/apache/lucene/util/ByteBlockPool.java:
##
@@ -234,6 +234,44 @@ public void append(final BytesRef bytes) {
append(bytes.bytes, bytes
mikemccand commented on code in PR #12778:
URL: https://github.com/apache/lucene/pull/12778#discussion_r1384692182
##
lucene/core/src/test/org/apache/lucene/util/TestByteBlockPool.java:
##
@@ -25,7 +24,34 @@
public class TestByteBlockPool extends LuceneTestCase {
- public
dungba88 commented on code in PR #12778:
URL: https://github.com/apache/lucene/pull/12778#discussion_r1384477425
##
lucene/core/src/test/org/apache/lucene/util/TestByteBlockPool.java:
##
@@ -25,7 +24,34 @@
public class TestByteBlockPool extends LuceneTestCase {
- public vo
dweiss commented on code in PR #12778:
URL: https://github.com/apache/lucene/pull/12778#discussion_r1384432877
##
lucene/core/src/test/org/apache/lucene/util/TestByteBlockPool.java:
##
@@ -25,7 +24,34 @@
public class TestByteBlockPool extends LuceneTestCase {
- public void
dungba88 opened a new pull request, #12778:
URL: https://github.com/apache/lucene/pull/12778
### Description
This fixes one of the TODO in https://github.com/apache/lucene/issues/12760
The random().nextInt is supposed to be banned, I'll use another API.
--
This is an automate
19 matches
Mail list logo
