mikemccand commented on code in PR #12778:
URL: https://github.com/apache/lucene/pull/12778#discussion_r1384692182


##########
lucene/core/src/test/org/apache/lucene/util/TestByteBlockPool.java:
##########
@@ -25,7 +24,34 @@
 
 public class TestByteBlockPool extends LuceneTestCase {
 
-  public void testReadAndWrite() throws IOException {
+  public void testAppendFromOtherPool() {
+    ByteBlockPool pool = new ByteBlockPool(new 
ByteBlockPool.DirectAllocator());
+    final int numBytes = atLeast(2 << 16);
+    byte[] bytes = new byte[numBytes];
+    for (int i = 0; i < numBytes; i++) {
+      bytes[i] = (byte) random().nextInt(256);

Review Comment:
   > It seems we are also banning the `random().nextInt()` call in #12771
   
   Sorry, no need to avoid this API -- it is unbanned now -- it was a false 
alarm!  Sorry for the scare :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to