mikemccand commented on code in PR #12778:
URL: https://github.com/apache/lucene/pull/12778#discussion_r1386504215
##########
lucene/core/src/java/org/apache/lucene/util/fst/NodeHash.java:
##########
@@ -289,21 +273,34 @@ public long getNodeAddress(long hashSlot) {
}
/**
- * Set the node address and bytes from the provided hash slot
+ * Set the node address from the provided hash slot
*
* @param hashSlot the hash slot to write to
* @param nodeAddress the node address
- * @param bytes the node bytes to be copied
*/
- public void setNode(long hashSlot, long nodeAddress, byte[] bytes) {
+ public void setNodeAddress(long hashSlot, long nodeAddress) {
assert fstNodeAddress.get(hashSlot) == 0;
fstNodeAddress.set(hashSlot, nodeAddress);
count++;
+ }
+ private void setBytes(long hashSlot, byte[] bytes) {
Review Comment:
Can we rename to maybe `copyNodeBytes` or so?
##########
lucene/core/src/java/org/apache/lucene/util/fst/NodeHash.java:
##########
@@ -289,21 +273,34 @@ public long getNodeAddress(long hashSlot) {
}
/**
- * Set the node address and bytes from the provided hash slot
+ * Set the node address from the provided hash slot
*
* @param hashSlot the hash slot to write to
* @param nodeAddress the node address
- * @param bytes the node bytes to be copied
*/
- public void setNode(long hashSlot, long nodeAddress, byte[] bytes) {
+ public void setNodeAddress(long hashSlot, long nodeAddress) {
assert fstNodeAddress.get(hashSlot) == 0;
fstNodeAddress.set(hashSlot, nodeAddress);
count++;
+ }
+ private void setBytes(long hashSlot, byte[] bytes) {
+ assert copiedNodeAddress.get(hashSlot) == 0;
copiedNodes.append(bytes);
// write the offset, which points to the last byte of the node we copied
since we later read
// this node in reverse
+ copiedNodeAddress.set(hashSlot, copiedNodes.getPosition() - 1);
+ }
+
+ /** promote the node bytes from the fallback table */
+ private void setBytes(
Review Comment:
Can we rename to `copyFallbackNodeBytes` or so?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
