Re: [PR] Adding filter to the toString() method of KnnFloatVectorQuery [lucene]

benwtrent merged PR #13990: URL: https://github.com/apache/lucene/pull/13990 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.a

Re: [PR] Adding filter to the toString() method of KnnFloatVectorQuery [lucene]

viswanathk commented on PR #13990: URL: https://github.com/apache/lucene/pull/13990#issuecomment-2483545431 > I think a `CHANGES` entry is in order. This seems like a nice little bug fix to aid folks in debugging issues. > > @viswanathk once you add the changes entry, I can merge and

Re: [PR] Adding filter to the toString() method of KnnFloatVectorQuery [lucene]

benwtrent commented on PR #13990: URL: https://github.com/apache/lucene/pull/13990#issuecomment-2474732022 > Unrelated: I noticed that the DiversifyingChildren* queries don't use the filter to evaluate the query, is this a bug? I am unsure what you mean by this? The filter is utilized

Re: [PR] Adding filter to the toString() method of KnnFloatVectorQuery [lucene]

benwtrent commented on code in PR #13990: URL: https://github.com/apache/lucene/pull/13990#discussion_r1841121411 ## lucene/join/src/java/org/apache/lucene/search/join/DiversifyingChildrenByteKnnVectorQuery.java: ## @@ -154,7 +154,14 @@ protected TopDocs approximateSearch(

Re: [PR] Adding filter to the toString() method of KnnFloatVectorQuery [lucene]

jpountz commented on PR #13990: URL: https://github.com/apache/lucene/pull/13990#issuecomment-2474335025 > Could you update the byte knn query & DiversifyingChildern* knn queries as well? Unrelated: I noticed that the `DiversifyingChildren*` queries don't use the filter to evaluate t

Re: [PR] Adding filter to the toString() method of KnnFloatVectorQuery [lucene]

jpountz commented on code in PR #13990: URL: https://github.com/apache/lucene/pull/13990#discussion_r1840915954 ## lucene/join/src/java/org/apache/lucene/search/join/DiversifyingChildrenByteKnnVectorQuery.java: ## @@ -154,7 +154,14 @@ protected TopDocs approximateSearch( @O

Re: [PR] Adding filter to the toString() method of KnnFloatVectorQuery [lucene]

viswanathk commented on code in PR #13990: URL: https://github.com/apache/lucene/pull/13990#discussion_r1838356398 ## lucene/join/src/java/org/apache/lucene/search/join/DiversifyingChildrenByteKnnVectorQuery.java: ## @@ -154,7 +154,14 @@ protected TopDocs approximateSearch(

Re: [PR] Adding filter to the toString() method of KnnFloatVectorQuery [lucene]

viswanathk commented on code in PR #13990: URL: https://github.com/apache/lucene/pull/13990#discussion_r1838356398 ## lucene/join/src/java/org/apache/lucene/search/join/DiversifyingChildrenByteKnnVectorQuery.java: ## @@ -154,7 +154,14 @@ protected TopDocs approximateSearch(

Re: [PR] Adding filter to the toString() method of KnnFloatVectorQuery [lucene]

viswanathk commented on code in PR #13990: URL: https://github.com/apache/lucene/pull/13990#discussion_r1838322211 ## lucene/join/src/java/org/apache/lucene/search/join/DiversifyingChildrenByteKnnVectorQuery.java: ## @@ -154,7 +154,14 @@ protected TopDocs approximateSearch(

Re: [PR] Adding filter to the toString() method of KnnFloatVectorQuery [lucene]

benwtrent commented on code in PR #13990: URL: https://github.com/apache/lucene/pull/13990#discussion_r1838315863 ## lucene/join/src/java/org/apache/lucene/search/join/DiversifyingChildrenByteKnnVectorQuery.java: ## @@ -154,7 +154,14 @@ protected TopDocs approximateSearch(

Re: [PR] Adding filter to the toString() method of KnnFloatVectorQuery [lucene]

viswanathk commented on PR #13990: URL: https://github.com/apache/lucene/pull/13990#issuecomment-2470836662 I hope I got all of them now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] Adding filter to the toString() method of KnnFloatVectorQuery [lucene]

jpountz commented on PR #13990: URL: https://github.com/apache/lucene/pull/13990#issuecomment-2470768672 I believe that @benwtrent meant `KnnByteVectorQuery`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] Adding filter to the toString() method of KnnFloatVectorQuery [lucene]

viswanathk commented on PR #13990: URL: https://github.com/apache/lucene/pull/13990#issuecomment-2470717378 > Could you update the byte knn query & DiversifyingChildern* knn queries as well? I made the changes fo DiversifyingChildren*, but by byteknn do you mean `ByteVectorSimilarity

Re: [PR] Adding filter to the toString() method of KnnFloatVectorQuery [lucene]

benwtrent commented on code in PR #13990: URL: https://github.com/apache/lucene/pull/13990#discussion_r1838141983 ## lucene/core/src/test/org/apache/lucene/search/TestKnnFloatVectorQuery.java: ## @@ -29,13 +29,7 @@ import org.apache.lucene.document.Field; import org.apache.luc