benwtrent commented on code in PR #13990:
URL: https://github.com/apache/lucene/pull/13990#discussion_r1838315863
##########
lucene/join/src/java/org/apache/lucene/search/join/DiversifyingChildrenByteKnnVectorQuery.java:
##########
@@ -154,7 +154,14 @@ protected TopDocs approximateSearch(
@Override
public String toString(String field) {
- return getClass().getSimpleName() + ":" + this.field + "[" + query[0] +
",...][" + k + "]";
Review Comment:
test updates for this and the float version? The tests are in:
TestParentBlockJoinByteKnnVectorQuery and of course the float version as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
