jpountz commented on code in PR #13990:
URL: https://github.com/apache/lucene/pull/13990#discussion_r1840915954
##########
lucene/join/src/java/org/apache/lucene/search/join/DiversifyingChildrenByteKnnVectorQuery.java:
##########
@@ -154,7 +154,14 @@ protected TopDocs approximateSearch(
@Override
public String toString(String field) {
- return getClass().getSimpleName() + ":" + this.field + "[" + query[0] +
",...][" + k + "]";
Review Comment:
It's not obvious to me, `parentsFilter` is more a property of the index than
of the query. You could have multiple levels of parents, which would make this
property relevant to print, but at the same time I don't think they have proper
toString() implementations. Let's leave it out for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
