Re: [PR] Add levels to DocValues skipper index [lucene]

2024-07-19 Thread via GitHub
iverase merged PR #13563: URL: https://github.com/apache/lucene/pull/13563 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Add levels to DocValues skipper index [lucene]

2024-07-18 Thread via GitHub
iverase commented on code in PR #13563: URL: https://github.com/apache/lucene/pull/13563#discussion_r1682694746 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesConsumer.java: ## @@ -207,65 +210,127 @@ void accumulate(long value) { maxValue = Mat

Re: [PR] Add levels to DocValues skipper index [lucene]

2024-07-18 Thread via GitHub
iverase commented on code in PR #13563: URL: https://github.com/apache/lucene/pull/13563#discussion_r1682671882 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesConsumer.java: ## @@ -207,65 +210,127 @@ void accumulate(long value) { maxValue = Mat

Re: [PR] Add levels to DocValues skipper index [lucene]

2024-07-18 Thread via GitHub
iverase commented on code in PR #13563: URL: https://github.com/apache/lucene/pull/13563#discussion_r1682656013 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesProducer.java: ## @@ -1792,61 +1794,91 @@ public DocValuesSkipper getSkipper(FieldInfo field

Re: [PR] Add levels to DocValues skipper index [lucene]

2024-07-18 Thread via GitHub
iverase commented on code in PR #13563: URL: https://github.com/apache/lucene/pull/13563#discussion_r1682654554 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesProducer.java: ## @@ -1792,61 +1794,91 @@ public DocValuesSkipper getSkipper(FieldInfo field

Re: [PR] Add levels to DocValues skipper index [lucene]

2024-07-18 Thread via GitHub
jpountz commented on code in PR #13563: URL: https://github.com/apache/lucene/pull/13563#discussion_r1682502283 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesConsumer.java: ## @@ -207,65 +210,127 @@ void accumulate(long value) { maxValue = Mat

Re: [PR] Add levels to DocValues skipper index [lucene]

2024-07-17 Thread via GitHub
iverase commented on code in PR #13563: URL: https://github.com/apache/lucene/pull/13563#discussion_r1681112760 ## lucene/test-framework/src/java/org/apache/lucene/tests/index/AssertingLeafReader.java: ## @@ -1194,24 +1194,27 @@ public int numLevels() { @Override publi

Re: [PR] Add levels to DocValues skipper index [lucene]

2024-07-17 Thread via GitHub
jpountz commented on code in PR #13563: URL: https://github.com/apache/lucene/pull/13563#discussion_r1681097434 ## lucene/test-framework/src/java/org/apache/lucene/tests/index/AssertingLeafReader.java: ## @@ -1194,24 +1194,27 @@ public int numLevels() { @Override publi

Re: [PR] Add levels to DocValues skipper index [lucene]

2024-07-17 Thread via GitHub
iverase commented on code in PR #13563: URL: https://github.com/apache/lucene/pull/13563#discussion_r1681096883 ## lucene/core/src/java/org/apache/lucene/index/CheckIndex.java: ## @@ -3301,17 +3301,17 @@ private static void checkDocValueSkipper(FieldInfo fi, DocValuesSkipper sk

Re: [PR] Add levels to DocValues skipper index [lucene]

2024-07-17 Thread via GitHub
iverase commented on code in PR #13563: URL: https://github.com/apache/lucene/pull/13563#discussion_r1681083206 ## lucene/test-framework/src/java/org/apache/lucene/tests/index/AssertingLeafReader.java: ## @@ -1194,24 +1194,27 @@ public int numLevels() { @Override publi

Re: [PR] Add levels to DocValues skipper index [lucene]

2024-07-17 Thread via GitHub
iverase commented on code in PR #13563: URL: https://github.com/apache/lucene/pull/13563#discussion_r1681082271 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesProducer.java: ## @@ -1792,61 +1794,91 @@ public DocValuesSkipper getSkipper(FieldInfo field

Re: [PR] Add levels to DocValues skipper index [lucene]

2024-07-17 Thread via GitHub
iverase commented on code in PR #13563: URL: https://github.com/apache/lucene/pull/13563#discussion_r1681081567 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesConsumer.java: ## @@ -207,65 +210,133 @@ void accumulate(long value) { maxValue = Mat

Re: [PR] Add levels to DocValues skipper index [lucene]

2024-07-17 Thread via GitHub
iverase commented on code in PR #13563: URL: https://github.com/apache/lucene/pull/13563#discussion_r1681080747 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesConsumer.java: ## @@ -207,65 +210,133 @@ void accumulate(long value) { maxValue = Mat

Re: [PR] Add levels to DocValues skipper index [lucene]

2024-07-17 Thread via GitHub
iverase commented on code in PR #13563: URL: https://github.com/apache/lucene/pull/13563#discussion_r1681080290 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesConsumer.java: ## @@ -207,65 +210,133 @@ void accumulate(long value) { maxValue = Mat

Re: [PR] Add levels to DocValues skipper index [lucene]

2024-07-17 Thread via GitHub
iverase commented on code in PR #13563: URL: https://github.com/apache/lucene/pull/13563#discussion_r1681079162 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesConsumer.java: ## @@ -207,65 +210,133 @@ void accumulate(long value) { maxValue = Mat

Re: [PR] Add levels to DocValues skipper index [lucene]

2024-07-17 Thread via GitHub
iverase commented on code in PR #13563: URL: https://github.com/apache/lucene/pull/13563#discussion_r1681076840 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesConsumer.java: ## @@ -207,65 +210,133 @@ void accumulate(long value) { maxValue = Mat

Re: [PR] Add levels to DocValues skipper index [lucene]

2024-07-17 Thread via GitHub
jpountz commented on code in PR #13563: URL: https://github.com/apache/lucene/pull/13563#discussion_r1680897686 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesConsumer.java: ## @@ -207,65 +210,133 @@ void accumulate(long value) { maxValue = Mat

Re: [PR] Add levels to DocValues skipper index [lucene]

2024-07-17 Thread via GitHub
iverase commented on code in PR #13563: URL: https://github.com/apache/lucene/pull/13563#discussion_r1680751732 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesProducer.java: ## @@ -1792,61 +1794,88 @@ public DocValuesSkipper getSkipper(FieldInfo field

Re: [PR] Add levels to DocValues skipper index [lucene]

2024-07-16 Thread via GitHub
jpountz commented on code in PR #13563: URL: https://github.com/apache/lucene/pull/13563#discussion_r1678955876 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesProducer.java: ## @@ -1792,61 +1794,88 @@ public DocValuesSkipper getSkipper(FieldInfo field

Re: [PR] Add levels to DocValues skipper index [lucene]

2024-07-15 Thread via GitHub
iverase commented on code in PR #13563: URL: https://github.com/apache/lucene/pull/13563#discussion_r1677661302 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesProducer.java: ## @@ -1792,61 +1794,88 @@ public DocValuesSkipper getSkipper(FieldInfo field

Re: [PR] Add levels to DocValues skipper index [lucene]

2024-07-15 Thread via GitHub
iverase commented on code in PR #13563: URL: https://github.com/apache/lucene/pull/13563#discussion_r1677637583 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesConsumer.java: ## @@ -207,65 +210,120 @@ void accumulate(long value) { maxValue = Mat

Re: [PR] Add levels to DocValues skipper index [lucene]

2024-07-15 Thread via GitHub
jpountz commented on code in PR #13563: URL: https://github.com/apache/lucene/pull/13563#discussion_r1677636214 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesProducer.java: ## @@ -1792,61 +1794,88 @@ public DocValuesSkipper getSkipper(FieldInfo field

Re: [PR] Add levels to DocValues skipper index [lucene]

2024-07-15 Thread via GitHub
iverase commented on code in PR #13563: URL: https://github.com/apache/lucene/pull/13563#discussion_r1677624311 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesProducer.java: ## @@ -1792,61 +1794,88 @@ public DocValuesSkipper getSkipper(FieldInfo field

Re: [PR] Add levels to DocValues skipper index [lucene]

2024-07-14 Thread via GitHub
jpountz commented on code in PR #13563: URL: https://github.com/apache/lucene/pull/13563#discussion_r1677204200 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesFormat.java: ## @@ -194,5 +194,34 @@ public DocValuesProducer fieldsProducer(SegmentReadStat

[PR] Add levels to DocValues skipper index [lucene]

2024-07-11 Thread via GitHub
iverase opened a new pull request, #13563: URL: https://github.com/apache/lucene/pull/13563 Currently the DocValues skipper index collects the stats every 4096 documents that allow implementors to used them to decide if they want to process those documents or they can be skipped. The idea o