iverase commented on code in PR #13563:
URL: https://github.com/apache/lucene/pull/13563#discussion_r1682654554
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesProducer.java:
##########
@@ -1792,61 +1794,91 @@ public DocValuesSkipper getSkipper(FieldInfo field)
throws IOException {
if (input.length() > 0) {
input.prefetch(0, 1);
}
+ // TODO: should we write to disk the actual max level for this segment?
return new DocValuesSkipper() {
- int minDocID = -1;
- int maxDocID = -1;
- long minValue, maxValue;
- int docCount;
+ final int[] minDocID = new int[SKIP_INDEX_MAX_LEVEL];
+ final int[] maxDocID = new int[SKIP_INDEX_MAX_LEVEL];
+
+ {
+ for (int i = 0; i < SKIP_INDEX_MAX_LEVEL; i++) {
+ minDocID[i] = maxDocID[i] = -1;
+ }
+ }
+
+ final long[] minValue = new long[SKIP_INDEX_MAX_LEVEL];
+ final long[] maxValue = new long[SKIP_INDEX_MAX_LEVEL];
+ final int[] docCount = new int[SKIP_INDEX_MAX_LEVEL];
+ int levels = 1;
@Override
public void advance(int target) throws IOException {
if (target > entry.maxDocId) {
- minDocID = DocIdSetIterator.NO_MORE_DOCS;
- maxDocID = DocIdSetIterator.NO_MORE_DOCS;
+ // skipper is exhausted
+ for (int i = 0; i < SKIP_INDEX_MAX_LEVEL; i++) {
+ minDocID[i] = maxDocID[i] = DocIdSetIterator.NO_MORE_DOCS;
+ }
} else {
+ // find next interval
+ assert target > maxDocID[0] : "target must be bigger that current
interval";
while (true) {
- maxDocID = input.readInt();
- if (maxDocID >= target) {
- minDocID = input.readInt();
- maxValue = input.readLong();
- minValue = input.readLong();
- docCount = input.readInt();
+ levels = input.readByte();
+ assert levels <= SKIP_INDEX_MAX_LEVEL && levels > 0
+ : "level out of range [" + levels + "]";
+ boolean competitive = true;
+ // check if current interval is competitive or we can jump to the
next position
+ for (int level = levels - 1; level >= 0; level--) {
+ if ((maxDocID[level] = input.readInt()) < target) {
+ input.skipBytes(SKIP_INDEX_JUMP_LENGTH_PER_LEVEL[level]); //
the jump for the level
+ competitive = false;
+ break;
+ }
+ minDocID[level] = input.readInt();
+ maxValue[level] = input.readLong();
+ minValue[level] = input.readLong();
+ docCount[level] = input.readInt();
+ }
+ if (competitive) {
+ // adjust levels
+ while (levels < SKIP_INDEX_MAX_LEVEL) {
+ if (maxDocID[levels] < target) {
+ break;
+ }
+ levels++;
+ }
Review Comment:
of course, the condition looks more like:
```java
while (levels < SKIP_INDEX_MAX_LEVEL && maxDocID[levels] >=
target) {
levels++;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
