iverase commented on code in PR #13563:
URL: https://github.com/apache/lucene/pull/13563#discussion_r1681079162
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesConsumer.java:
##########
@@ -207,65 +210,133 @@ void accumulate(long value) {
maxValue = Math.max(maxValue, value);
}
+ void accumulate(SkipAccumulator other) {
+ minDocID = Math.min(minDocID, other.minDocID);
+ maxDocID = Math.max(maxDocID, other.maxDocID);
Review Comment:
Done. The assert need to be `minDocID <= other.minDocId && maxDocId <
other.maxDocID)` because we initializr the accumulator with the minDocID
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
