github-actions[bot] commented on PR #13594:
URL: https://github.com/apache/lucene/pull/13594#issuecomment-2564883454
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
dungba88 commented on PR #13594:
URL: https://github.com/apache/lucene/pull/13594#issuecomment-2543393217
@benwtrent sorry for the delay. I have addressed the comments. Can you
please take a look? Thank you
--
This is an automated message from the Apache Git Service.
To respond to the mes
github-actions[bot] commented on PR #13594:
URL: https://github.com/apache/lucene/pull/13594#issuecomment-2506880785
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
dungba88 commented on code in PR #13594:
URL: https://github.com/apache/lucene/pull/13594#discussion_r1843000812
##
lucene/core/src/java/org/apache/lucene/search/AnnQueryUtils.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
benwtrent commented on code in PR #13594:
URL: https://github.com/apache/lucene/pull/13594#discussion_r1842215165
##
lucene/core/src/java/org/apache/lucene/search/AnnQueryUtils.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
dungba88 commented on PR #13594:
URL: https://github.com/apache/lucene/pull/13594#issuecomment-2475301572
Thanks Kaival for reviewing and approving.
Could someone from Lucene committers help review and merge this PR if it
looks good?
--
This is an automated message from the Apache
github-actions[bot] commented on PR #13594:
URL: https://github.com/apache/lucene/pull/13594#issuecomment-2303335718
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
dungba88 commented on code in PR #13594:
URL: https://github.com/apache/lucene/pull/13594#discussion_r1705038897
##
lucene/core/src/java/org/apache/lucene/search/KnnQueryUtils.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
kaivalnp commented on code in PR #13594:
URL: https://github.com/apache/lucene/pull/13594#discussion_r1704945107
##
lucene/core/src/java/org/apache/lucene/search/KnnQueryUtils.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
dungba88 commented on PR #13594:
URL: https://github.com/apache/lucene/pull/13594#issuecomment-2249529412
There were some recent commits I need to rebase first as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
dungba88 commented on PR #13594:
URL: https://github.com/apache/lucene/pull/13594#issuecomment-2249206205
I think common utility makes sense. I'll move both createFilterWeights and
createBitSet to a utility class.
--
This is an automated message from the Apache Git Service.
To respond to
kaivalnp commented on PR #13594:
URL: https://github.com/apache/lucene/pull/13594#issuecomment-2247150383
+1 to share as much logic as possible (including `createFilterWeight`). The
`FieldExistsQuery` proposal (to only collect pre-filtered docs which have
vectors) seems promising too
dungba88 opened a new pull request, #13594:
URL: https://github.com/apache/lucene/pull/13594
### Description
- Add comments to methods for easier to understand their behaviors
- Remove duplicate codes to createBitSet used in both the main top-k KNN
query and vector similarity query
13 matches
Mail list logo
