dungba88 opened a new pull request, #13594: URL: https://github.com/apache/lucene/pull/13594
### Description - Add comments to methods for easier to understand their behaviors - Remove duplicate codes to createBitSet used in both the main top-k KNN query and vector similarity query - Also remove unused variable `weight` To discuss: The `createFilterWeight` might also merit to be shared with the vector similarity query. There is a discrepancy between the 2 classes: the top-k KNN query enhance the filter so that only documents having values on the KNN field will be matched, but the vector similarity query doesn't. I think they should share similar behavior as they are both vector search. Moreover, should we make their behavior more closely so that they can share/extend one another? The top-k KNN query has the main logic inside rewriteQuery while vector-similarity query has the main logic in Weight. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
