kaivalnp commented on PR #13594: URL: https://github.com/apache/lucene/pull/13594#issuecomment-2247150383
+1 to share as much logic as possible (including `createFilterWeight`). The `FieldExistsQuery` proposal (to only collect pre-filtered docs which have vectors) seems promising too > they can share/extend one another? IMO we should not tie `AbstractVectorSimilarityQuery` and `AbstractKnnVectorQuery` because they compute results differently (in the scorer v/s rewrite) which has broader implications (eg the similarity query is cacheable, inherent parallelism across segments, etc) Maybe some common KNN utility classes / functions instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
