jpountz merged PR #14748:
URL: https://github.com/apache/lucene/pull/14748
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
jpountz merged PR #14747:
URL: https://github.com/apache/lucene/pull/14747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
jpountz merged PR #14749:
URL: https://github.com/apache/lucene/pull/14749
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
jpountz merged PR #14739:
URL: https://github.com/apache/lucene/pull/14739
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
vsop-479 commented on PR #14749:
URL: https://github.com/apache/lucene/pull/14749#issuecomment-2933058801
Thanks @jpountz !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
vsop-479 closed issue #14677: Does LRUQueryCache#uniqueQueries really needs
wrapped by Collections.synchronizedMap?
URL: https://github.com/apache/lucene/issues/14677
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
vsop-479 commented on issue #14677:
URL: https://github.com/apache/lucene/issues/14677#issuecomment-2933056790
Oh, You are right @benwtrent !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
gf2121 commented on code in PR #14716:
URL: https://github.com/apache/lucene/pull/14716#discussion_r2121634772
##
lucene/core/src/java/org/apache/lucene/index/PostingsEnum.java:
##
@@ -63,6 +87,12 @@ public abstract class PostingsEnum extends DocIdSetIterator {
*/
public
jpountz opened a new pull request, #14750:
URL: https://github.com/apache/lucene/pull/14750
We often need to divide the doc ID space into sub windows, but this is prone
to integer overflows if the size of the window is greater than
`Integer.MAX_VALUE - windowStart`. This adds `MathUtil#unsi
jpountz opened a new pull request, #14749:
URL: https://github.com/apache/lucene/pull/14749
It may not be totally obvious why this map needs to be synchronized since
reads and writes are performed under a read-write lock. Except that unlike most
other collections, reads are not thread-safe
jpountz commented on issue #14677:
URL: https://github.com/apache/lucene/issues/14677#issuecomment-2931141062
Argh, of-couse, thank you @benwtrent! I opened a PR so that it's more
obvious to readers of this code in the future: #14749.
--
This is an automated message from the Apache Git Se
romseygeek commented on code in PR #14748:
URL: https://github.com/apache/lucene/pull/14748#discussion_r2121218882
##
lucene/core/src/java/org/apache/lucene/search/DocAndFloatFeatureBuffer.java:
##
@@ -21,29 +21,32 @@
import org.apache.lucene.util.IntsRef;
/**
- * Wrapper ar
jpountz commented on issue #14746:
URL: https://github.com/apache/lucene/issues/14746#issuecomment-2930378258
This was the reasoning behind the introduction of `ReadAdvice.RANDOM`. By
telling the operating system that the file has a random access pattern, it
should be able to optimize for t
martijnvg commented on code in PR #14672:
URL: https://github.com/apache/lucene/pull/14672#discussion_r2121019535
##
lucene/core/src/java/org/apache/lucene/search/comparators/NumericComparator.java:
##
@@ -328,120 +507,47 @@ private void updateSkipInterval(boolean success) {
benwtrent commented on issue #14677:
URL: https://github.com/apache/lucene/issues/14677#issuecomment-2930565960
@vsop-479 @jpountz maybe my understanding of how LinkedHashMaps work is
wrong. But: https://github.com/apache/lucene/pull/13306#discussion_r1578328936
It seems to me that if
jpountz commented on issue #14677:
URL: https://github.com/apache/lucene/issues/14677#issuecomment-2930396347
It looks like you are right, we could remove the wrapper.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
jpountz closed issue #14719: Potential resource leakage in
WordDictionary#loadMainDataFromFile
URL: https://github.com/apache/lucene/issues/14719
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jpountz commented on issue #14719:
URL: https://github.com/apache/lucene/issues/14719#issuecomment-2930382910
Fixed via #14727
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
jpountz opened a new pull request, #14748:
URL: https://github.com/apache/lucene/pull/14748
I initially kept those separated but I'm now coming to the conclusion that
they should be merged:
- While frequencies are ints today, some queries produce float frequencies
(`SloppyPhraseQuery`,
jpountz opened a new pull request, #14747:
URL: https://github.com/apache/lucene/pull/14747
This aims at simplifying things a bit to make it easier to implement
`CombinedFieldScorer#nextDocsAndScores` later.
--
This is an automated message from the Apache Git Service.
To respond to the me
github-actions[bot] commented on PR #14747:
URL: https://github.com/apache/lucene/pull/14747#issuecomment-2929530021
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the skip-changelog-check
label to it and you wil
github-actions[bot] commented on PR #14716:
URL: https://github.com/apache/lucene/pull/14716#issuecomment-2929379478
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the skip-changelog-check
label to it and you wil
jpountz commented on code in PR #14716:
URL: https://github.com/apache/lucene/pull/14716#discussion_r2120387948
##
lucene/core/src/java/org/apache/lucene/index/PostingsEnum.java:
##
@@ -63,6 +87,12 @@ public abstract class PostingsEnum extends DocIdSetIterator {
*/
public
jpountz commented on code in PR #14716:
URL: https://github.com/apache/lucene/pull/14716#discussion_r2120389716
##
lucene/core/src/java/org/apache/lucene/index/PostingsEnum.java:
##
@@ -63,6 +87,12 @@ public abstract class PostingsEnum extends DocIdSetIterator {
*/
public
jpountz commented on code in PR #14716:
URL: https://github.com/apache/lucene/pull/14716#discussion_r2120356527
##
lucene/core/src/java/org/apache/lucene/index/PostingsEnum.java:
##
@@ -63,6 +87,12 @@ public abstract class PostingsEnum extends DocIdSetIterator {
*/
public
jpountz commented on code in PR #14716:
URL: https://github.com/apache/lucene/pull/14716#discussion_r2120355953
##
lucene/core/src/java/org/apache/lucene/index/TermsEnum.java:
##
@@ -170,11 +170,15 @@ public final PostingsEnum postings(PostingsEnum reuse)
throws IOException {
26 matches
Mail list logo
