jainankitk merged PR #14638:
URL: https://github.com/apache/lucene/pull/14638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
jainankitk commented on PR #14638:
URL: https://github.com/apache/lucene/pull/14638#issuecomment-2868349476
Related #14609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
jainankitk opened a new pull request, #14638:
URL: https://github.com/apache/lucene/pull/14638
### Description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
jainankitk commented on PR #14609:
URL: https://github.com/apache/lucene/pull/14609#issuecomment-2868309175
Thanks @ebradshaw for this change, and congratulations on your first
contribution in lucene! :)
--
This is an automated message from the Apache Git Service.
To respond to the messag
jainankitk merged PR #14609:
URL: https://github.com/apache/lucene/pull/14609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
Kwanghyuk-Kim opened a new issue, #14637:
URL: https://github.com/apache/lucene/issues/14637
### Description
Hello Mainters of Nori Analyzer,
Recently, we upgraded ElasticSearch from v6.8 to v8.1 and installed Nori
analyzer plugin corresponds with v8.1 ElasticSearch.
And
mkhludnev merged PR #14636:
URL: https://github.com/apache/lucene/pull/14636
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.a
mikemccand commented on PR #14633:
URL: https://github.com/apache/lucene/pull/14633#issuecomment-2867787360
+1 to eliminate the crazy `success` pattern! I hope we can also eliminate
even the `success2` cases :)
Thank you @thecoop for fixing this!
--
This is an automated message fr
mikemccand commented on issue #14630:
URL: https://github.com/apache/lucene/issues/14630#issuecomment-2867812786
> Yikes, I will revert back to JDK 23 temporarily
Oh, hmmm, maybe not -- JDK 23 EOL'd.
--
This is an automated message from the Apache Git Service.
To respond to the mess
mikemccand commented on issue #14630:
URL: https://github.com/apache/lucene/issues/14630#issuecomment-2867811509
Yikes, I will revert back to JDK 23 temporarily and see if the regression
goes away. That is a big drop for some queries, e.g.
[`VectorSearch`](https://benchmarks.mikemccandless
jainankitk commented on code in PR #14609:
URL: https://github.com/apache/lucene/pull/14609#discussion_r2082377177
##
lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java:
##
@@ -580,4 +557,111 @@ public final String toString(String field) {
* @return human rea
jainankitk commented on issue #14399:
URL: https://github.com/apache/lucene/issues/14399#issuecomment-2867626533
@jpountz - Any thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
jainankitk closed issue #13335: Multi range traversal for numeric range
aggregations
URL: https://github.com/apache/lucene/issues/13335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
jainankitk commented on issue #13335:
URL: https://github.com/apache/lucene/issues/13335#issuecomment-2867622763
I guess we can close this issue now -
https://github.com/apache/lucene/blob/main/lucene/CHANGES.txt#L97
--
This is an automated message from the Apache Git Service.
To respond
gf2121 merged PR #14552:
URL: https://github.com/apache/lucene/pull/14552
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
ChrisHegarty commented on code in PR #14604:
URL: https://github.com/apache/lucene/pull/14604#discussion_r2081913839
##
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99HnswVectorsReader.java:
##
@@ -110,7 +111,10 @@ public Lucene99HnswVectorsReader(SegmentReadStat
gf2121 merged PR #14618:
URL: https://github.com/apache/lucene/pull/14618
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
jainankitk merged PR #14622:
URL: https://github.com/apache/lucene/pull/14622
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
jainankitk commented on PR #14622:
URL: https://github.com/apache/lucene/pull/14622#issuecomment-2867308579
Merging this change as it primarily adds new benchmark, and small bug fix
with significant performance impact (more than 10x). Ran the unit tests locally
for 10k iterations to confirm
mkhludnev opened a new pull request, #14632:
URL: https://github.com/apache/lucene/pull/14632
…point occurs in the edge
### Description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
mkhludnev merged PR #14632:
URL: https://github.com/apache/lucene/pull/14632
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.a
mkhludnev opened a new pull request, #14636:
URL: https://github.com/apache/lucene/pull/14636
…… (#14632)
* fix TestSortedDvMultiRangeQuery.testDuelWithStandardDisjunction when point
occurs in the edge
### Description
--
This is an automated message from the Apac
uschindler commented on code in PR #14604:
URL: https://github.com/apache/lucene/pull/14604#discussion_r2081775573
##
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99HnswVectorsReader.java:
##
@@ -110,7 +111,10 @@ public Lucene99HnswVectorsReader(SegmentReadState
thecoop commented on PR #14635:
URL: https://github.com/apache/lucene/pull/14635#issuecomment-2866689635
Oops - copy/paste error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
uschindler commented on PR #14633:
URL: https://github.com/apache/lucene/pull/14633#issuecomment-2866618642
The reason for that problem is in the JLS:
https://docs.oracle.com/javase/specs/jls/se24/html/jls-11.html#jls-11.2.2
> A throw statement whose thrown expression is a final or ef
thecoop commented on PR #14633:
URL: https://github.com/apache/lucene/pull/14633#issuecomment-2866538943
Unfortunately that doesn't work here - Java forgets the specific exception
types thrown in the try when the exception goes in & out of the generic method
- it infers `T` to `Throwable`,
jpountz opened a new pull request, #14635:
URL: https://github.com/apache/lucene/pull/14635
- more javadocs to guide usage of `INDEX` vs. `DATA`,
- the `METADATA` constant is removed, as metadata files should be opened
with `Directory#openChecksumIndexInput`, which doesn't take hints,
ChrisHegarty commented on PR #14604:
URL: https://github.com/apache/lucene/pull/14604#issuecomment-2866648054
> Ahh, I saw the constant on `MMapDirectory` and failed to see that it was
unused.
We can of course choose to change this - enable preLoad Hints by default,
but I'd rather se
uschindler commented on PR #14633:
URL: https://github.com/apache/lucene/pull/14633#issuecomment-2866593107
Indeed that does not work. I was under the impression that the compiler
should be able to see that the method parameter has same type as return type by
this. Looks like that's not ful
jpountz commented on code in PR #14635:
URL: https://github.com/apache/lucene/pull/14635#discussion_r2081723072
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingTermVectorsReader.java:
##
@@ -149,10 +148,7 @@ public Lucene90CompressingTerm
jpountz commented on PR #14635:
URL: https://github.com/apache/lucene/pull/14635#issuecomment-2866598164
cc @thecoop @ChrisHegarty
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
jpountz commented on PR #14604:
URL: https://github.com/apache/lucene/pull/14604#issuecomment-2866603763
Ahh, I saw the constant on `MMapDirectory` and failed to see that it was
unused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
uschindler commented on PR #14633:
URL: https://github.com/apache/lucene/pull/14633#issuecomment-2866550770
> Unfortunately that doesn't work here - Java forgets the specific exception
types thrown in the try when the exception goes in & out of the generic method
- it infers `T` to `Throwab
jpountz commented on code in PR #14634:
URL: https://github.com/apache/lucene/pull/14634#discussion_r2081686750
##
lucene/codecs/src/java/org/apache/lucene/codecs/memory/FSTTermsReader.java:
##
@@ -75,7 +76,8 @@ public FSTTermsReader(SegmentReadState state,
PostingsReaderBase p
jpountz commented on PR #14634:
URL: https://github.com/apache/lucene/pull/14634#issuecomment-2866543005
cc @thecoop @ChrisHegarty
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
jpountz opened a new pull request, #14634:
URL: https://github.com/apache/lucene/pull/14634
This enables the `PreloadHint` introduced in #14604 on completion fields and
memory terms dictionaries, which are both expected to fit in the page cache in
practice.
I don't have specific inte
thecoop commented on PR #14604:
URL: https://github.com/apache/lucene/pull/14604#issuecomment-2866518576
After comments from @ChrisHegarty, this PR does not change the default
behaviour. You need to use the hint by calling
`MMapDirectory.setPreload(PRELOAD_HINT)`
--
This is an automated
uschindler commented on PR #14633:
URL: https://github.com/apache/lucene/pull/14633#issuecomment-2866499124
I have a suggestion. I used the same approach in the expressions module to
patch the stack trace and rethrowing exceptions (to include the source code of
the exception into the stack
uschindler commented on PR #14633:
URL: https://github.com/apache/lucene/pull/14633#issuecomment-2866504083
P.S.: Here is the bytecode of the Expression patching:
https://github.com/apache/lucene/pull/14602#issuecomment-2845328503
Small note: As this is generated bytecode the generics
thecoop commented on PR #14633:
URL: https://github.com/apache/lucene/pull/14633#issuecomment-2866484934
@uschindler PR updated. I've applied this refactor to the most recent set of
formats, as those are most likely to be copied in future format changes. That
seems like a good place to leav
The MMapDir changes are also only moving around class files, no
functional changes.
Am 09.05.2025 um 14:32 schrieb thecoop (via GitHub):
thecoop commented on issue #14630:
URL: https://github.com/apache/lucene/issues/14630#issuecomment-2866376125
The JDK 24 upgrade is included in that diff
jpountz commented on PR #14604:
URL: https://github.com/apache/lucene/pull/14604#issuecomment-2866464348
Can you add a CHANGES entry for this? Similar changes have not always been
well received in the past, because it increases the cost of opening a reader,
even though the reader may not ne
thecoop commented on code in PR #14633:
URL: https://github.com/apache/lucene/pull/14633#discussion_r2081616824
##
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene101/Lucene101PostingsReader.java:
##
@@ -120,23 +119,21 @@ public Lucene101PostingsReader(Se
thecoop commented on issue #14630:
URL: https://github.com/apache/lucene/issues/14630#issuecomment-2866376125
The JDK 24 upgrade is included in that diff - that may be most likely? The
other wide-ranging changes are the MMapDirectory change and the first IOContext
PR, but those are both int
jpountz commented on code in PR #14609:
URL: https://github.com/apache/lucene/pull/14609#discussion_r2081563312
##
lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java:
##
@@ -580,4 +534,114 @@ public final String toString(String field) {
* @return human readab
uschindler commented on code in PR #14633:
URL: https://github.com/apache/lucene/pull/14633#discussion_r2081556092
##
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene101/Lucene101PostingsReader.java:
##
@@ -120,23 +119,21 @@ public Lucene101PostingsReader
uschindler commented on PR #14633:
URL: https://github.com/apache/lucene/pull/14633#issuecomment-2866336273
Hi,
In general at the time when the success code was written a catch/rethrow of
Throwable would not compile without an inappropriate throws clause on the
method. Because the java c
ChrisHegarty commented on issue #14623:
URL: https://github.com/apache/lucene/issues/14623#issuecomment-2866257196
Thanks @javanna - that captures the dilemma very well, and I really
appreciate the devil’s advocate angle. Your summary gets to the heart of the
issue: early adoption is good f
ChrisHegarty merged PR #14604:
URL: https://github.com/apache/lucene/pull/14604
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucen
thecoop opened a new pull request, #14633:
URL: https://github.com/apache/lucene/pull/14633
The use of a boolean `success` parameter is common in the Lucene codebase.
This can be replaced with a `catch (Throwable t) {...; throw t}` pattern that
means a boolean doesn't need to be used at all
javanna commented on issue #14623:
URL: https://github.com/apache/lucene/issues/14623#issuecomment-2866023747
I read your comments and I am also nervous about extending the compatibility
that Lucene currently offers. I totally get the point around backporting after
baking time in main, and
thecoop commented on code in PR #14604:
URL: https://github.com/apache/lucene/pull/14604#discussion_r2081391127
##
lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java:
##
@@ -136,7 +137,8 @@ public class MMapDirectory extends FSDirectory {
private BiFunction>
r
ChrisHegarty commented on code in PR #14604:
URL: https://github.com/apache/lucene/pull/14604#discussion_r2081375455
##
lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java:
##
@@ -136,7 +137,8 @@ public class MMapDirectory extends FSDirectory {
private BiFunctio
ChrisHegarty commented on code in PR #14604:
URL: https://github.com/apache/lucene/pull/14604#discussion_r2081339388
##
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99HnswVectorsReader.java:
##
@@ -110,7 +111,10 @@ public Lucene99HnswVectorsReader(SegmentReadStat
thecoop closed pull request #14631: Refactor KnnVectorReader merging to not
need a finishMerge method
URL: https://github.com/apache/lucene/pull/14631
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
thecoop opened a new pull request, #14631:
URL: https://github.com/apache/lucene/pull/14631
Use a similar pattern to other `getMergeInstance` methods - clone the input,
and set the new context on it, rather than setting & resetting the read advice
on the main instance.
This also remo
javanna commented on PR #14524:
URL: https://github.com/apache/lucene/pull/14524#issuecomment-2865817224
Thanks for clarifying @Shibi-bala .
I get a bit confused here with the mention of query fairness. What #13472
does is advance execution on the caller thread, that would otherwise
ChrisHegarty merged PR #14629:
URL: https://github.com/apache/lucene/pull/14629
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucen
ChrisHegarty merged PR #14510:
URL: https://github.com/apache/lucene/pull/14510
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucen
59 matches
Mail list logo
