ChrisHegarty commented on code in PR #14604:
URL: https://github.com/apache/lucene/pull/14604#discussion_r2081339388
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99HnswVectorsReader.java:
##########
@@ -110,7 +111,10 @@ public Lucene99HnswVectorsReader(SegmentReadState state,
FlatVectorsReader flatV
Lucene99HnswVectorsFormat.VECTOR_INDEX_EXTENSION,
Lucene99HnswVectorsFormat.VECTOR_INDEX_CODEC_NAME,
state.context.withHints(
- FileTypeHint.DATA, FileDataHint.KNN_VECTORS,
DataAccessHint.RANDOM));
+ FileTypeHint.DATA,
+ FileDataHint.KNN_VECTORS,
+ DataAccessHint.RANDOM,
+ PreloadHint.INSTANCE));
Review Comment:
We've not preloaded this before. But I think it is ok, since it's just a
hint to the IndexInput, which by default will be be ignored - since one needs
to provide a preLoadOverride to MMapDirectory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
