uschindler commented on PR #14633: URL: https://github.com/apache/lucene/pull/14633#issuecomment-2866336273
Hi, In general at the time when the success code was written a catch/rethrow of Throwable would not compile without an inappropriate throws clause on the method. Because the java compiler got better in type tracking, the rethrow would not impose that a Throwable needs to be declared on the method declaration, as the compiler knows which checked exceptions could appear in the catch clause and can restrict types of possible checked exceptions. So in general I am +1 to do this. Code is cleaner and the suppressed exceptions are also much better. I have not checked modified logic in the PR, but the overall direction looks fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
